[8.10][patch] nm-connection-editor menu item untranslatable

I created the attached patch that would fix the problem. Pre-built packages also at my PPA (I couldn't create a bazaar branch since LP bzr seemed non-functional somehow).

I would have now created a bzr branch but I cannot find an existing bzr with the current revision 0.7~~svn20081020t000444-0ubuntu1.

11:42 [freenode] [msg(Mirv)] given that a template import/translation export round is unlikely before
          release, can we do this in a SRU after release?
11:42 [freenode] [msg(Mirv)] please attach the branch to the bug (e.g. link a related branch) and ask for
          merging to the "packaging branch"
11:43 [freenode] [msg(Mirv)] thanks.

approved for intrepid, but not milestoning -> SRU candidate.

Bzr branch https://code.edge.launchpad.net/~timo-jyrinki/network-manager-applet/menuitem-i18n-fix/ (lp:~timo-jyrinki/network-manager-applet/menuitem-i18n-fix).

Ping / SRU?

have you tried to built the package and all with this change?

Yes, like I mentioned in my first comment I've it in my PPA. I've had the 0.7~~svn20081020t000444-0ubuntu2 from http://ppa.launchpad.net/timo-jyrinki/ubuntu/pool/main/n/network-manager-applet/ installed since I created it, with the addition that I also updated the installed language-pack's .mo file to reflect what would be eventually gotten via language packs from Rosetta when the .pot file would be created using this version of network-manager-applet and .po files updated to have the new strings. With the .mo file installed, the menu entry is correctly shown as translated using this new version of nm-applet.

rev 481

This bug was fixed in the package network-manager-applet - 0.7~~svn20081020t000444-0ubuntu2

---------------
network-manager-applet (0.7~~svn20081020t000444-0ubuntu2) jaunty; urgency=low

  * fix LP: #289466 - Network Manager 0.7 applet not Appearing if there are
    managed entries in /etc/network/interfaces; we always call
    applet_schedule_update_icon in client_init; also we also show the try when
    there are error conditions (no NM running, no managed device)
    - add debian/patches/lp289464_always_show_tray_icon.patch
    - update debian/patches/series
  * fix LP: #286421 - nm-connection-editor menu item untranslatable;
    add i18n support to nm-connection-editor.desktop; patch by Timo Jyrinki
    <email address hidden>
    - add debian/patches/lp286421_fix_i18n_bug_286421.patch
    - update debian/patches/series
  * fix LP: #268803 - Ubuntu Intrepid: Both Knetworkmanager and Network
    Manager load on startup; fix xdg autostart .desktop file to
    "OnlyShowIn=GNOME;XFCE;"
    - add debian/patches/lp268803_xdg_autostart_gnome_xfce_only.patch
    - update debian/patches/series
  * fix LP: #293749 - prefix vs. netmask translation inconsistencies in
    connection-editor causes confusion; we cherry pick rev1009 from upstream
    svn and backport that.
    - add debian/patches/lp293749_better_prefix_netmask_ui.patch
    - update debian/patches/series

 -- Alexander Sack <email address hidden> Mon, 01 Dec 2008 14:05:51 +0100

Uploaded:

network-manager-applet_0.7~~svn20081020t000444-0ubuntu1.8.10.1_source.changes
network-manager-applet_0.7~~svn20081020t000444-0ubuntu2_source.changes

Accepted into intrepid-proposed, please test and give feedback here. Please see https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

I can confirm that the updated network-manager-applet package works for me. That it actually fixes the bug can be seen at https://translations.launchpad.net/ubuntu/intrepid/+source/network-manager-applet/+pots/nm-applet - with the new -proposed upload 2 new strings have appeared in each language, providing means for translators to add the menu entry translation for future language pack updates to Ubuntu 8.10.

This bug was fixed in the package network-manager-applet - 0.7~~svn20081020t000444-0ubuntu1.8.10.1

---------------
network-manager-applet (0.7~~svn20081020t000444-0ubuntu1.8.10.1) intrepid-proposed; urgency=low

  * fix LP: #289466 - Network Manager 0.7 applet not Appearing if there are
    managed entries in /etc/network/interfaces; we always call
    applet_schedule_update_icon in client_init; also we also show the try when
    there are error conditions (no NM running, no managed device)
    - add debian/patches/lp289464_always_show_tray_icon.patch
    - update debian/patches/series
  * fix LP: #286421 - nm-connection-editor menu item untranslatable;
    add i18n support to nm-connection-editor.desktop; patch by Timo Jyrinki
    <email address hidden>
    - add debian/patches/lp286421_fix_i18n_bug_286421.patch
    - update debian/patches/series
  * fix LP: #268803 - Ubuntu Intrepid: Both Knetworkmanager and Network
    Manager load on startup; fix xdg autostart .desktop file to
    "OnlyShowIn=GNOME;XFCE;"
    - add debian/patches/lp268803_xdg_autostart_gnome_xfce_only.patch
    - update debian/patches/series
  * fix LP: #293749 - prefix vs. netmask translation inconsistencies in
    connection-editor causes confusion; we cherry pick rev1009 from upstream
    svn and backport that.
    - add debian/patches/lp293749_better_prefix_netmask_ui.patch
    - update debian/patches/series

 -- Alexander Sack <email address hidden> Mon, 01 Dec 2008 14:05:51 +0100

fwiw, also fixed in 0.7 final from upstream.

Launchpad Bug Tracker wrote:
> This bug was fixed in the package network-manager-applet -
> 0.7~~svn20081020t000444-0ubuntu1.8.10.1
>
> ---------------
> network-manager-applet (0.7~~svn20081020t000444-0ubuntu1.8.10.1) intrepid-proposed; urgency=low
>
> * fix LP: #289466 - Network Manager 0.7 applet not Appearing if there are
> managed entries in /etc/network/interfaces; we always call
> applet_schedule_update_icon in client_init; also we also show the try when
> there are error conditions (no NM running, no managed device)
> - add debian/patches/lp289464_always_show_tray_icon.patch
> - update debian/patches/series
> * fix LP: #286421 - nm-connection-editor menu item untranslatable;
> add i18n support to nm-connection-editor.desktop; patch by Timo Jyrinki
> <email address hidden>
> - add debian/patches/lp286421_fix_i18n_bug_286421.patch
> - update debian/patches/series
> * fix LP: #268803 - Ubuntu Intrepid: Both Knetworkmanager and Network
> Manager load on startup; fix xdg autostart .desktop file to
> "OnlyShowIn=GNOME;XFCE;"
> - add debian/patches/lp268803_xdg_autostart_gnome_xfce_only.patch
> - update debian/patches/series
> * fix LP: #293749 - prefix vs. netmask translation inconsistencies in
> connection-editor causes confusion; we cherry pick rev1009 from upstream
> svn and backport that.
> - add debian/patches/lp293749_better_prefix_netmask_ui.patch
> - update debian/patches/series
>
> -- Alexander Sack <email address hidden> Mon, 01 Dec 2008 14:05:51 +0100
>
> ** Changed in: network-manager-applet (Ubuntu Intrepid)
> Status: Fix Committed => Fix Released
>
>