[SRU] Update firmware to support autofocus

Bug #2052575 reported by Pallav Joshi
22
This bug affects 2 people
Affects Status Importance Assigned to Milestone
linux-firmware-xilinx-ap1302 (Ubuntu)
In Progress
Undecided
Unassigned
Focal
Invalid
Undecided
Unassigned
Jammy
Fix Committed
Undecided
Unassigned
Mantic
Fix Committed
Undecided
Unassigned

Bug Description

[Impact]

     * This will add/enable support for autofocus feature in ap1302 firmware.
     * This is essential for ap1302 to work on rev 2.0 kv260 boards

[Where Problems could occur]

     * Since the change is only on ap1302 firmware, it could only break Kria kv260 apps that uses the camera firmware on Xilinx boards.
     * Rev 1.0 will still not be able to use autofocus feature (hw limitation). It will continue to have existing functionality.
     * It is backward compatible and will not break anything else and not have any other side effects.

[Test Case]

      * This is tested with Smartcam application on Kria Kv260 Rev 1.0 and Rev 2.0 boards.
      * Detail setup and application deployment link: https://xilinx.github.io/kria-apps-docs/kv260/2022.1/build/html/docs/smartcamera/smartcamera_landing.html

      * Testing Environment:
        - Setup will be in Normal light levels (~500 Lux)
        - Test with ISO Chart input at various distances 30cm, 60cm, 90 cm.
        - Test with multiple face input image at various distances as above.
        - Place the multiple objects before the camera to check if the focus would be on single object.
      * Object at different distances should be auto focused.

[Regression Potential]
      * Smartcam application must be tested on Rev1.0 to ensure backward compatibility [Verified].

[Other Information]
      * Github tag/src: https://github.com/Xilinx/ap1302-firmware/tree/v2.0
      * Required version number: Change the versioning scheme and make this as version 2.0 (with epoch 1:2.0)
      * Tested with local personal PPA:
             [Old] https://launchpad.net/~vishal-p/+archive/ubuntu/ppa/+packages
         [Updated] https://launchpad.net/~joshipallav/+archive/ubuntu/pre-release/+packages
      * Targeted for Jammy

Tags: patch
Revision history for this message
Pallav Joshi (joshipallav) wrote :
Revision history for this message
Pallav Joshi (joshipallav) wrote :

Backport of 2.0 for mantic

Revision history for this message
Pallav Joshi (joshipallav) wrote :

Backport for jammy

Revision history for this message
Pallav Joshi (joshipallav) wrote :

Backport to focal

Revision history for this message
Talha Can Havadar (tchavadar) wrote :

I subscribed the ubuntu-sponsors

Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in linux-firmware-xilinx-ap1302 (Ubuntu):
status: New → Confirmed
Revision history for this message
Julian Andres Klode (juliank) wrote :

Subscribing ~ubuntu-xilinx as this was previously maintained by them afaict and regular patch pilots like me don't have the knowledge to judge this or what their plans are, if any.

Changed in linux-firmware-xilinx-ap1302 (Ubuntu):
status: Confirmed → Incomplete
Revision history for this message
Dave Jones (waveform) wrote :

The debdiffs are unfortunately rather pointless given they just list "Binary files blah and blah differ", i.e. they can't be used to build the package for sponsoring. I see there's a jammy build in the test PPA, but this will need fixing in noble before backporting anywhere else. I would suggest providing a PPA containing a build for each affected release (or a git repo with a branch per affected release), but I'm afraid debdiffs won't be any use here.

I've targetted the series according to the debdiffs provided, but I'll leave this marked "Incomplete" until a noble source package can be provided.

Revision history for this message
Steve Langasek (vorlon) wrote :

As noted, there is currently nothing here to sponsor. Unsubscribing ubuntu-sponsors, please resubscribe when there is something that can be upladed.

Revision history for this message
Pallav Joshi (joshipallav) wrote (last edit ):

Hi Dave,

Thanks for your comments.

I have added a package for nobel and a package for jammy in the following PPA:
https://launchpad.net/~joshipallav/+archive/ubuntu/pre-release/+packages

Please let me know if anything else is needed.

As for the target. This package is only targeted for jammy and nobel, we don't expect it to be available in mantic or focal. So please drop the support for those distributions.

description: updated
Changed in linux-firmware-xilinx-ap1302 (Ubuntu):
status: Incomplete → In Progress
Dave Jones (waveform)
Changed in linux-firmware-xilinx-ap1302 (Ubuntu Focal):
status: New → Invalid
Revision history for this message
Dave Jones (waveform) wrote :

I've set focal to "invalid", but I'm not sure we can support skipping a release for a package. I *think* I'm right in saying that upgraders have to pass through interim releases for as long as they exist, which would force the removal of this package upon people moving from jammy to noble (until mantic EOL's).

Revision history for this message
Pallav Joshi (joshipallav) wrote :
Revision history for this message
Pallav Joshi (joshipallav) wrote :
Revision history for this message
Dave Jones (waveform) wrote :

Okay, this looks good, sponsoring packages from PPA.

Revision history for this message
Timo Aaltonen (tjaalton) wrote :

the changelog didn't have a reference to this bug... uploads rejected

Revision history for this message
Dave Jones (waveform) wrote :

Re-uploaded with bug ref

Revision history for this message
Łukasz Zemczak (sil2100) wrote : Please test proposed package

Hello Pallav, or anyone else affected,

Accepted linux-firmware-xilinx-ap1302 into mantic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/linux-firmware-xilinx-ap1302/1:2.0-0ubuntu1~23.10.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-mantic to verification-done-mantic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-mantic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in linux-firmware-xilinx-ap1302 (Ubuntu Mantic):
status: New → Fix Committed
Changed in linux-firmware-xilinx-ap1302 (Ubuntu Jammy):
status: New → Fix Committed
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Hello Pallav, or anyone else affected,

Accepted linux-firmware-xilinx-ap1302 into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/linux-firmware-xilinx-ap1302/1:2.0-0ubuntu1~22.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.