The currently existing 'virt-pki-validate' on Ubuntu 10.04 has some flaws, which I've tried to correct in the attached patch.
- It changes the interpreter to /bin/bash instead of /bin/sh, this removes an 'unexpected operator' warning which can occur on line 140.
- Removed references to SYSCONFDIR and changed those to '/etc'.
- Corrected a 'sed' call to remove a tab from the line it is formatting, in order to make the rest of the checks in the script work properly.
There are still some references to '/etc/sysconfig/iptables' in the script, which does not exist on Ubuntu. This should probably either be changed to check the UFW configuration, current loaded iptables rules, or simply be removed from the check. However, these checks are skipped when '/etc/sysconfig/iptables' does not exist.
Dustin, do you think it's reasonable to fix this in the same post-RC libvirt upload ?