[SRU] konversation defaults to #debian/irc.debian.org if kubuntu-default-settings is not installed

Bug #218958 reported by Michael Banck
10
Affects Status Importance Assigned to Milestone
konversation (Ubuntu)
Fix Released
High
Unassigned
Intrepid
Fix Released
High
Unassigned
Jaunty
Fix Released
High
Unassigned

Bug Description

Binary package hint: konversation

01:13 -!- ubuntu (Live session user) [~ubuntu@79-68-161-178.dynamic.dsl.as9105.com] has joined #debian
01:13 * ubuntu found a bug in hardy beta disk
01:13 < ubuntu> if you install konversation, it comes to #debian with the ubuntu nickname :D
01:14 < azeem> ubuntu: as in, default channel is #debian?
01:14 < ubuntu> yup

It seems konversation connects to #debian/irc.debian.org by default if installed on non-kubuntu (e.g. Ubuntu LiveCD):

01:29 < Ace2016_-> its ubuntu live cd with konversation installed
01:30 < azeem> Ace2016_-: so you manually installed konversation?
01:30 < Ace2016_-> yup

Maybe just adding a dependency on kubuntu-default-settings might be enough:

01:33 < azeem> Ace2016_-: if you try to install kubuntu-default-settings, how many other packages are getting installed?
01:34 < Ace2016_-> none other are getting installed

Anyway, I hope this can be fixed for hardy, as Ubuntu users are not welcome in #debian, and this is probably not going to change, so we should protect those people from getting there by accident.

Michael

Revision history for this message
Sarah Kowalik (hobbsee-deactivatedaccount) wrote :

Fixed, thanks.

(I'm currently looking for how this got in there in the first place)

Changed in konversation:
status: New → Fix Released
Revision history for this message
Sarah Kowalik (hobbsee-deactivatedaccount) wrote :

Looks like Riddell missed this when he was merging from debian.

Changed in konversation:
importance: Undecided → High
milestone: none → ubuntu-8.04
assignee: nobody → hobbsee
Revision history for this message
Stuart Prescott (themill) wrote :

This appears to be a problem again in 8.10. Edited extract from #debian on oftc:

[23:47] <ubuntu> how do i get to ubuntu channel?
[23:47] <ubuntu> #ubuntu dont work

[23:49] <themill> ubuntu: go to #ubuntu on irc.freenode.net

[23:50] <ubuntu> so how do i get to freenod, im useing konversation it should be freenod when i start it up

[23:51] <themill> ubuntu: did konversation automatically join you to #debian too? (which version of ubuntu?)

[23:51] <ubuntu> 8.10

[23:51] <ubuntu> this was the channel it started up with
[23:51] <themill> ubuntu: /server irc.freenode.net

Revision history for this message
Sarah Kowalik (hobbsee-deactivatedaccount) wrote :

Argh, Richard Birnie <email address hidden> has done a bad merge after my changes, and has dropped at least this change. Goodness knows what else is gone either.

This will be SRU material.

Changed in konversation:
status: Fix Released → Triaged
assignee: hobbsee → rbirnie
milestone: ubuntu-8.04 → none
Changed in konversation:
assignee: nobody → rbirnie
importance: Undecided → High
status: New → Triaged
Changed in konversation:
assignee: rbirnie → hobbsee
status: Triaged → In Progress
Changed in konversation:
status: In Progress → Fix Committed
Revision history for this message
Sarah Kowalik (hobbsee-deactivatedaccount) wrote :

Right. Patch very carefully done, and uploaded to jaunty (currently frozen) & PPA. Looks like the rest of the changes aren't required anymore, but i've added back in all the missing changelog entries, added the kubuntu channel patch, and removed the debian one.

Statement explaining the impact:
Users who install konversation on Ubuntu without kubuntu-default-settings installed will be sent to #debian on freenode by default, not #kubuntu.

How the bug has been addressed: Added previous kubuntu patch (excluding the port change, which upstream has taken), and removed the debian patch. The kubuntu patch has been in kubuntu for many months, without problems. Hardy has this patch in it already.

Instructions how to reproduce the bug
Make sure kubuntu-default-settings is not installed. Start konversation. Look at which network it autojoins to (it says freenode), and which channel (it says #debian). Make sure you don't talk in #debian, else the above may happen to you.
TEST CASE: Install version from -proposed. Let it autojoin. See that it joins #kubuntu on 'Ubuntu IRC', whether kubuntu-default-settings is installed or not.

Regression potential: Very low. We have a very similar patch in hardy, with no problems. This is a very simple fix.

Changed in konversation:
assignee: rbirnie → hobbsee
status: Triaged → In Progress
Revision history for this message
Sarah Kowalik (hobbsee-deactivatedaccount) wrote :

Uploaded to -proposed, diff at http://hobbsee.com/tmp/kubuntu.debdiff

Revision history for this message
Richard Birnie (rbirnie-deactivatedaccount) wrote :

"Richard Birnie <email address hidden> has done a bad merge after my changes, and has dropped at least this change."

This was one of the very first merges I ever did. If I broke something I apologise.

Revision history for this message
Martin Pitt (pitti) wrote :

Accepted into intrepid-proposed, please test and give feedback here. Please see https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Changed in konversation:
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package konversation - 1.1-0ubuntu3

---------------
konversation (1.1-0ubuntu3) jaunty; urgency=low

  * Reapply kubuntu_05_default_channels.diff dropped in 1.0.1-6ubuntu1.
  * Removed 10_debian_channel.diff added in 1.0.1-6ubuntu1.
  * Re-add missing changelog entries that went into a black hole.
  * Kubuntu people now go to #kubuntu, not #debian again (LP: #218958),
    even without kubuntu-default-settings installed.
  * This merge should now be correct.

 -- Sarah Hobbs <email address hidden> Tue, 04 Nov 2008 13:23:34 +1100

Changed in konversation:
status: Fix Committed → Fix Released
Revision history for this message
Jonathan Thomas (echidnaman) wrote :

The fix in intrepid-proposed works for me.

Revision history for this message
Martin Pitt (pitti) wrote :

Copied to intrepid-updates.

Changed in konversation:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.