[SRU/Gutsy]: Two patches for gtkpod-aac

Bug #163283 reported by John Dong
6
Affects Status Importance Assigned to Milestone
gtkpod-aac (Ubuntu)
Fix Released
Medium
John Dong

Bug Description

Binary package hint: gtkpod-aac

This is a combination of #135178 and #145506, being handled as one SRU for timeliness. They are independent patches and I will detail testing information for both.

=== Streamlined Verification Procedures ===
This procedure will test both bugs at the same time.

(1) Move any existing ~/.gtkpod to somewhere else as a backup
(2) Start gtkpod
(3) Click Local on the left pane
(4) On the toolbar, hit Add File
(5) Find a .mp4 .m4v or .m4a file and add it. Google filetype:m4a for sample files

EXPECTED BEHAVIOR:
 File is added and now shows up in the local repository
DEFECTIVE BEHAVIOR:
 (1) If #145506 is unfixed, an error dialog pops up asking you to insert the iPod assocated with the repository first. Of course, there's no iPod associated with a local repo
 (2) If #135178 is unfixed, an error dialog pops up saying there is no support for .mp4 format.

==== PERTAINING TO #135178 =====
 The new upstream gtkpod release tries to implement the "Group" metadata field for MP4, which requires a newer libmp4v2 than Gutsy has. This causes ./configure to build without AAC/MP4 support. The patch I provide reverts to previous Gtkpod behavior of ignoring the "Group" metadata tag for .mp4 files.

TEST CASE:
Try to use gtkpod to add a .mp4 file onto an iPod.

EXPECTED BEHAVIOR:
Gtkpod adds the file to your iPod

DEFECTIVE BEHAVIOR:
Gtkpod informs user that it was compiled without mp4 support.

ALTERNATE TEST (i.e. non iPod owners):
Look at build log output at the end of ./configure phase

EXPECTED BEHAVIOR:
./configure reports that it will build with MP4/AAC support

DEFECTIVE BEHAVIOR:
./configure reports that it will build without MP4/AAC support
This description was updated.

===== PERTAINING TO #145506 =======
DESCRIPTION:
Newly created local repositories are not set as "imported" internally, which causes gtkpod to output a nonsensical error about inserting an iPod (which doesn't exist for local repos at all) before adding tracks. A patch was picked out of gtkpod's svn that addresses this issue specifically by setting the local repositories' "imported" flag.

VERIFICATION: (no iPod necessary)
Remove ~/.gtkpod -- that is, start with a fresh configuration. Open up Gtkpod and click the Local repository. On the tool bar, click either Add File or Add Dir

EXPECTED BEHAVIOR:
A dialog comes up to choose what to add

DEFECTIVE BEHAVIOR:
An error box pops up asking you to insert an iPod.

Revision history for this message
John Dong (jdong) wrote :
Revision history for this message
John Dong (jdong) wrote :
John Dong (jdong)
description: updated
Revision history for this message
Emmet Hikory (persia) wrote :

This doesn't need sponsorship anymore, so I'm pulling it from queue. Congratulations.

Changed in gtkpod-aac:
assignee: nobody → jdong
importance: Undecided → Medium
status: New → In Progress
Revision history for this message
Jonathan Riddell (jr) wrote :

accepted to gutsy-proposed, please test

Changed in gtkpod-aac:
status: In Progress → Fix Committed
Revision history for this message
Roger (rogeralexanderdean) wrote :

Streamlined test worked for me. mp4 file added successfully
Many thanks to all
Roger

Revision history for this message
Glenn (glenn-strong) wrote :

Test of #135178 worked for me: mp4 added to iPod successfully. Thanks!

Revision history for this message
Jacob Hannan (hannanjf) wrote :

Installed version from gutsy-proposed and followed Streamlined Verification Procedures. It worked on both issues.

Thanks!

Revision history for this message
John Dong (jdong) wrote :

Marking verification done; thanks verifiers.

Revision history for this message
Martin Pitt (pitti) wrote :

Copied to gutsy-updates.

Changed in gtkpod-aac:
status: Fix Committed → Fix Released
Revision history for this message
Alex Cornejo (acornejoc) wrote :

This bug is not fixed in gtkpod on Gutsy with latest updates, it seems the patch was only applied to gtkpod-aac, but gtkpod remains affected.

Revision history for this message
John Dong (jdong) wrote :

Which bug on Gutsy? The local repository not accepting music?

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.