[SRU/Gutsy]: Two patches for gtkpod-aac
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
gtkpod-aac (Ubuntu) |
Fix Released
|
Medium
|
John Dong |
Bug Description
Binary package hint: gtkpod-aac
This is a combination of #135178 and #145506, being handled as one SRU for timeliness. They are independent patches and I will detail testing information for both.
=== Streamlined Verification Procedures ===
This procedure will test both bugs at the same time.
(1) Move any existing ~/.gtkpod to somewhere else as a backup
(2) Start gtkpod
(3) Click Local on the left pane
(4) On the toolbar, hit Add File
(5) Find a .mp4 .m4v or .m4a file and add it. Google filetype:m4a for sample files
EXPECTED BEHAVIOR:
File is added and now shows up in the local repository
DEFECTIVE BEHAVIOR:
(1) If #145506 is unfixed, an error dialog pops up asking you to insert the iPod assocated with the repository first. Of course, there's no iPod associated with a local repo
(2) If #135178 is unfixed, an error dialog pops up saying there is no support for .mp4 format.
==== PERTAINING TO #135178 =====
The new upstream gtkpod release tries to implement the "Group" metadata field for MP4, which requires a newer libmp4v2 than Gutsy has. This causes ./configure to build without AAC/MP4 support. The patch I provide reverts to previous Gtkpod behavior of ignoring the "Group" metadata tag for .mp4 files.
TEST CASE:
Try to use gtkpod to add a .mp4 file onto an iPod.
EXPECTED BEHAVIOR:
Gtkpod adds the file to your iPod
DEFECTIVE BEHAVIOR:
Gtkpod informs user that it was compiled without mp4 support.
ALTERNATE TEST (i.e. non iPod owners):
Look at build log output at the end of ./configure phase
EXPECTED BEHAVIOR:
./configure reports that it will build with MP4/AAC support
DEFECTIVE BEHAVIOR:
./configure reports that it will build without MP4/AAC support
This description was updated.
===== PERTAINING TO #145506 =======
DESCRIPTION:
Newly created local repositories are not set as "imported" internally, which causes gtkpod to output a nonsensical error about inserting an iPod (which doesn't exist for local repos at all) before adding tracks. A patch was picked out of gtkpod's svn that addresses this issue specifically by setting the local repositories' "imported" flag.
VERIFICATION: (no iPod necessary)
Remove ~/.gtkpod -- that is, start with a fresh configuration. Open up Gtkpod and click the Local repository. On the tool bar, click either Add File or Add Dir
EXPECTED BEHAVIOR:
A dialog comes up to choose what to add
DEFECTIVE BEHAVIOR:
An error box pops up asking you to insert an iPod.
This doesn't need sponsorship anymore, so I'm pulling it from queue. Congratulations.