[gutsy SRU] gtkpod-aac does not live up to its name

Bug #135178 reported by Alex Wauck
30
Affects Status Importance Assigned to Milestone
gtkpod-aac (Ubuntu)
Fix Released
Undecided
Emmet Hikory
Gutsy
Invalid
Undecided
John Dong
Hardy
Fix Released
Undecided
Emmet Hikory

Bug Description

Binary package hint: gtkpod-aac

DESCRIPTION:

gtkpod-aac is not compiled with mp4/aac support in Gutsy. When I tried to recompile the package with mp4/aac support, it failed. gtkpod-aac worked as expected in Feisty.
 [Added by John Dong:]
  The new upstream gtkpod release tries to implement the "Group" metadata field for MP4, which requires a newer libmp4v2 than Gutsy has. This causes ./configure to build without AAC/MP4 support. The patch I provide reverts to previous Gtkpod behavior of ignoring the "Group" metadata tag for .mp4 files.

TEST CASE:
Try to use gtkpod to add a .mp4 file onto an iPod.

EXPECTED BEHAVIOR:
Gtkpod adds the file to your iPod

DEFECTIVE BEHAVIOR:
Gtkpod informs user that it was compiled without mp4 support.

ALTERNATE TEST (i.e. non iPod owners):
Look at build log output at the end of ./configure phase

EXPECTED BEHAVIOR:
./configure reports that it will build with MP4/AAC support

DEFECTIVE BEHAVIOR:
./configure reports that it will build without MP4/AAC support

Revision history for this message
schalkpd (schalkpd+launchpad) wrote :

Same exact problem here on latest Gutsy i386. When I try to build it (from the source at gtkpod.org) it cannot find libmp4v2 despite the fact I have both libmp4v2-0 and libmp4v2-dev installed. Maybe this is a problem with libmp4v2-dev?

Revision history for this message
Matteo Settenvini (tchernobog) wrote :

The problem is while configuring the package from source. Since a commit in gtkpod dated about June 7th, 2007, the configure script searches for the symbol MP4GetMetadataGrouping into libmp4v2.
However, for some reason, this symbol isn't present / exported. So I expect the problem is either:
a) with libmp3v2, which isn't exporting a symbol it should
b) with gtkpod, which tries to use an undocumented/obsolete API removed in the gutsy release of libmp3v2
c) wrong versions of required dependencies of gtkpod-aac

Unfortunately, I don't have a lot of time to investigate on this. Can someone take this bug?

Revision history for this message
Alex Wauck (awauck) wrote :

A quick grep indicates that the string "MP4GetMetadataGrouping" does not occur anywhere in the libmp4v2 (actually libfaad) source code as fetched by "apt-get source libmp4v2-0".

Revision history for this message
Alex Wauck (awauck) wrote :

Also, MP4GetMetadataGrouping only occurs in one place in gtkpod-aac.

Revision history for this message
Alex Wauck (awauck) wrote :

Here's another fun tidbit: we're at faad2 version 2.0.0 (the full version string is 2.0.0+cvs20040908+mp4v2+bmp-0ubuntu5), while 2.5 was released over a year ago. However, the real problem seems to be that libmp4v2, which Ubuntu/Debian rolled into libfaad2 for some strange reason, is at version 0.9.8.6, but mpeg4ip, which appears to be the origin of libmp4v2, has released version 1.5.0.1, which has MP4GetMetaDatagrouping. Here's a crazy idea: why don't we package libmp4v2 separately and get it and libfaad2 up to date while we're at it?

Revision history for this message
John Dong (jdong) wrote :

Well, it's clearly too late in Gutsy's release cycle to import new libmp4v2, so unfortunately looks like we won't be able to ship a functioning gtkpod-aac.

Can we rip it out of the archive so we don't go confusing users about it?

Revision history for this message
welktach (welktach) wrote :

I was able to successfully compile gtkpod from SVN on Fesity and Gusty by installing libmp4v2-dev from the Debian repositories, which depended on libmp4v2, libmpeg4ip, and libmpeg4ip-dev.

dr who (dr-who)
Changed in gtkpod-aac:
status: New → Confirmed
Revision history for this message
John Dong (jdong) wrote :

Hi everyone,

I've been working on this bug and unless someone has an objection I'd like to fix this for Gutsy and Hardy. Long story short, GTKPod now tries to get and set grouping information from MP4 metadata and that requires a newer libmp4v2 than we have. Since upgrading mp4v2 seems to be a bigger job than it would seem, I have chosen to just roll back the grouping checking for mp4's altogether. I am currently still build testing these packages and will keep everyone up to date on the situation. My plan is to first upload the fix to Hardy, then carry through to SRU this change to Gutsy.

Changed in gtkpod-aac:
assignee: nobody → jdong
Revision history for this message
John Dong (jdong) wrote :

Debdiff for hardy -- builds/works inside a pbuilder.

Revision history for this message
John Dong (jdong) wrote :

Here's the debdiff for gutsy-proposed.

Will provide pbuilder testing debs soon.

Revision history for this message
John Dong (jdong) wrote :

Here is a deb built using prevu (pbuilder + version bump down to backports level) of the gutsy-proposed debdiff.

This works for me for adding an AAC music file and a MP4 video file onto my 5G iPod. Please help test to make the SRU process go faster.

Revision history for this message
Aaron Sarna (shoofy) wrote :

I successfully transfered a .m4a AAC file to my ipod using this version.

Emmet Hikory (persia)
Changed in gtkpod-aac:
assignee: nobody → jdong
status: New → Confirmed
assignee: jdong → persia
status: Confirmed → In Progress
Revision history for this message
Emmet Hikory (persia) wrote :

Uploaded. Thanks. Would you mind adjusting the gutsy-proposed patch to include a (preferably more verbose) description of the patch?

Changed in gtkpod-aac:
status: In Progress → Fix Committed
Revision history for this message
Emmet Hikory (persia) wrote :

gtkpod-aac (0.99.10-2ubuntu2) hardy; urgency=low

  [ John Dong ]
  * disable-mp4-grouping.dpatch: Disable MP4 grouping retrieval
    as our libmp4v2 doesn't support it (LP: #135178)

  [ Emmet Hikory ]
  * Add the description for the dpatch

 -- Emmet Hikory <email address hidden> Tue, 06 Nov 2007 00:17:25 +0900

Changed in gtkpod-aac:
status: Fix Committed → Fix Released
Revision history for this message
John Dong (jdong) wrote :
Revision history for this message
Matteo Settenvini (tchernobog) wrote :

Although this solution is good for Gutsy, I think that for Hardy it'd be better to update the libfaad2 and libmp4v2 packages. Else, we could be experiencing further drift and patches needed for those programs using newer features of these two libs. Also, some developers use the -dev pkgs for their work, so even if we can do without upgrading, some users would like to anyway.

Anyway, *this* bug is fixed. Probably it'd make sense to open a _new_ bug about updating libfaad2 and libmp4v2 to latest version in Hardy.

Revision history for this message
John Dong (jdong) wrote : Re: [Bug 135178] Re: [gutsy] gtkpod-aac does not live up to its name

Agreed, that is still on my list of intentions. It will require much
more coordination with MOTU-media than this simple noninvasive patch but
let's get it done for Hardy.

Revision history for this message
Casey Hendley (elcasey) wrote : Re: [gutsy] gtkpod-aac does not live up to its name

Just another confirmation that John's debdiff worked for me on Gutsy as well.

Revision history for this message
John Dong (jdong) wrote :

I have verified the Hardy package to correctly parse MP4 headers and can recommend the Gutsy debdiff for -proposed.

John Dong (jdong)
description: updated
Revision history for this message
John Dong (jdong) wrote :

u-u-s: Please *DO NOT* upload said debdiff to gutsy-proposed -- I am rolling this together with bug #145506 into a single SRU (crimsun said it was okay)

Subscribers: Please see bug #163283 to contribute/follow the progress towards gutsy-updates.

Revision history for this message
Emmet Hikory (persia) wrote :

I've unsubscribed ubuntu-universe-sponsors based on the last comment.

Revision history for this message
John Dong (jdong) wrote :

Handled in other aforementioned bug #

Changed in gtkpod-aac:
status: Confirmed → Invalid
Revision history for this message
John Dong (jdong) wrote :

As a note to Matteo and others, I am currently working on bringing mpeg4ip into Hardy and reenabling full AAC tagging support :) Cheers!

Revision history for this message
Manuel Zach (loogaroo) wrote :

Just another confirmation, the package for gutsy (gtkpod-aac_0.99.10-2ubuntu1.1%7E7.10prevu1_i386.deb) works also for me, thx alot.

Revision history for this message
John Dong (jdong) wrote :

Attention all Gutsy users:

I could really use your help at https://bugs.launchpad.net/ubuntu/+source/gtkpod-aac/+bug/163283

This package is in gutsy-proposed and must be tested and confirmed by two people (don't have to be developers, anyone's fine) in order to be accepted to gutsy-updates. One of the bugs it fixes is this one. Please help me in testing it, that's the only thing preventing everyone from receiving this update!

Revision history for this message
Casimir (tyler-v) wrote :

Tested and confirmed that the version in gutsy-proposed works and transfers m4a files

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.