Save as button should be default focus

Bug #433207 reported by Oleksij Rempel
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
GNOME media utilities
Fix Released
Medium
One Hundred Papercuts
Fix Released
Low
Unassigned
gnome-media (Ubuntu)
Fix Released
Low
Ubuntu Desktop Bugs

Bug Description

gnome-sound-recorder use default not save option. On the close dialog "Save recording befor closing?" it use "Close without saving" as default option. Instead it should "Save As" as default answer.

lsb_release -rd
Description: Ubuntu karmic (development branch)
Release: 9.10

apt-cache policy gnome-media
gnome-media:
  Installiert: 2.27.91-0ubuntu1
  Kandidat: 2.27.91-0ubuntu1
  Versions-Tabelle:
 *** 2.27.91-0ubuntu1 0
        500 http://de.archive.ubuntu.com karmic/main Packages
        100 /var/lib/dpkg/status

Related branches

Revision history for this message
Oleksij Rempel (olerem) wrote :
Revision history for this message
Oleksij Rempel (olerem) wrote :

This patch fix this issue for me. Please do not ask to make better putch... i do not have time, really.

Revision history for this message
Oleksij Rempel (olerem) wrote :

screenshot after patch

Revision history for this message
Oleksij Rempel (olerem) wrote :
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thank you for your bug report and work there, maybe you could also open an upstream bug with your change?

Changed in gnome-media (Ubuntu):
assignee: nobody → Ubuntu Desktop Bugs (desktop-bugs)
importance: Undecided → Low
Revision history for this message
Oleksij Rempel (olerem) wrote : Re: [Bug 433207] Re: primary should be save optio.

I'll do it.

Oleksij Rempel (olerem)
Changed in gnome-media:
importance: Undecided → Unknown
status: New → Unknown
Changed in gnome-media:
status: Unknown → New
Revision history for this message
Sebastien Bacher (seb128) wrote : Re: primary should be save optio.

Thank you for sending the bug to GNOME

Changed in gnome-media (Ubuntu):
status: New → Triaged
Revision history for this message
Oleksij Rempel (olerem) wrote :
Revision history for this message
Sebastien Bacher (seb128) wrote :

thank you for your work there, you might want to subscribe ubuntu-main-sponsors for review, doing that now

Vish (vish)
Changed in hundredpapercuts:
importance: Undecided → Low
milestone: none → lucid-round-6
status: New → Triaged
Andrew (and471)
summary: - primary should be save optio.
+ Save as button should be default focus
Revision history for this message
Tralalalala (tralalalala) wrote :

You've fixed this bug by swapping both buttons. Now "Save As" is on the left side and "Close without Saving" is on the right side. In my opinion that's not the correct way of fixing the bug. The focus should be moved from the left button to the right button.

Having "Save As" on the left side and "Close without Saving" on the right side doesn't match the behavior of other Gnome applications. Look at Gedit. It has the "Close without Saving" button on the left and "Save As" on the right and the right button has the focus. Swapping these buttons will break Gnomes consistent behavior. Users expect the "Save As" button to be on the right side, just like in Gedit or the GIMP. Users are used to clicking the right button to save. If the buttons are swapped in Sound Recorder users will lose their work after instinctively clicking the right button.

Revision history for this message
Oleksij Rempel (olerem) wrote :

@Patrick, thank you for the comment.

Here is the new version

Revision history for this message
Sebastien Bacher (seb128) wrote :

Thank you for your work there

Changed in gnome-media (Ubuntu):
status: Triaged → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-media - 2.28.1-1ubuntu2

---------------
gnome-media (2.28.1-1ubuntu2) lucid; urgency=low

  * debian/patches/07_make-save-as-default-option.patch:
    - default to save as in the saving dialog, thank Alexey Fisher (lp: #433207)
  * debian/patches/08_fix_wrong-behavior-on-cancel.patch:
    - don't close the software when cancel is used on the saving dialog,
      thank Alexey Fisher (lp: #432395)
 -- Sebastien Bacher <email address hidden> Wed, 16 Dec 2009 17:03:49 +0100

Changed in gnome-media (Ubuntu):
status: Fix Committed → Fix Released
Vish (vish)
Changed in hundredpapercuts:
status: Triaged → Fix Released
Changed in gnome-media:
importance: Unknown → Medium
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.