Enable automated tests

Bug #2058401 reported by Jeremy Bícha
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
freerdp3 (Ubuntu)
In Progress
Medium
Nathan Teodosio

Bug Description

freerdp's packaging has set -DBUILD_TESTING=OFF

We need to try to enable that option to enable either build tests or autopkgtests or both.

If it doesn't work in at least one of Ubuntu's build or autopkgtest environments, we should document this.

Tags: noble patch
Changed in freerdp3 (Ubuntu):
assignee: nobody → Nathan Teodosio (nteodosio)
status: Triaged → In Progress
Revision history for this message
Nathan Teodosio (nteodosio) wrote :

The following debdiff enables the build tests and runs them as autopkgtests, which as per [1] run successfully.

[1] https://autopkgtest.ubuntu.com/results/autopkgtest-noble-nteodosio-rebuilds/noble/amd64/f/freerdp3/20240326_213622_91f66@/log.gz

Revision history for this message
Nathan Teodosio (nteodosio) wrote :

Actually please hold that for a moment, I had forgotten to enable other architectures in the PPA and a test is failing in Armhf.

Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "freerdp3.diff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

tags: added: patch
Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :

Nathan, I am removing ubuntu-sponsors from this bug as per your request to hold off. Please, subscribe it back to this bug once you believe it is ready.

Revision history for this message
Nathan Teodosio (nteodosio) wrote :

OK, we don't care about Armhf on Noble so I'm subscribing ubuntu-sponsors again.

Revision history for this message
Paride Legovini (paride) wrote :

+1 for enabling build-time testing, but that does not make an autopkgtest.

Autopkgtests should test the package as installed in an Ubuntu system; rebuilding the package (you have Restrictions: build-needed) and re-running the upstream test suite in the build tree adds nothing to the tests run at build time. Moreover you have extra build-deps installed this way, which make the autopkgtest result even less reliable.

It is fine to run the upstream test suite as an autopkgtest, but only if you can can make it use the software installed from the .deb package.

Revision history for this message
Nathan Teodosio (nteodosio) wrote :

Thanks for the review. I'm then unsubscribing ubuntu-sponsors and will subscribe again when I have a new patch.

Revision history for this message
Nathan Teodosio (nteodosio) wrote :

I tried this with 'autopkgtest -B . -- schroot noble-amd64' and the autopkgtest succeeded.

Revision history for this message
Nathan Teodosio (nteodosio) wrote :
Revision history for this message
Jeremy Bícha (jbicha) wrote :

I am handling this via Debian and the changes will be synced to Oracular soon. Therefore, I am unsubscribing ubuntu-sponsors. Feel free to resubscribe if you have something else that needs to be sponsored.

I pushed the autopkgtests there but I needed to add a commit to fix some issues seen there:
https://salsa.debian.org/debian-remote-team/freerdp3/-/commit/f814cdf193

I opened a merge request to get some more feedback from an upstream developer about why enabling build tests lead to a major increase in exported symbols:
https://salsa.debian.org/debian-remote-team/freerdp3/-/merge_requests/4

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.