Please convert init script to upstart.

Bug #603285 reported by Chuck Short
16
This bug affects 2 people
Affects Status Importance Assigned to Milestone
dovecot (Ubuntu)
Fix Released
Wishlist
Unassigned

Bug Description

Please review the upstart script that was converted from sys-v init scripts. I have attached the debdiff for your review. If you have any questions please let me know.

chuck

Tags: patch
Revision history for this message
Chuck Short (zulcss) wrote :
Revision history for this message
Colin Watson (cjwatson) wrote :

The job itself looks OK, although I have a few related questions:

Shouldn't you be using dh_installinit to install the job and deal with migrating the old conffile? Simply dropping the new job in place and removing the call to dh_installinit is generally not the correct thing to do.

The old init script has a few specialised warts that you don't seem to have preserved. Obviously a lot of it goes away with Upstart, but I think the inetd.conf check (even though it's clunky) is probably worth preserving. What about the ntp-wait gubbins? I can't think of an easy way to do "start on started ntpd but only if it's installed" in Upstart, so you may have to preserve that too for the moment.

tags: added: patch
Revision history for this message
Clint Byrum (clint-fewbar) wrote :

Status is Triaged, as this is ready for review.
Importance is Wishlist, as this is new functionality.

Changed in dovecot (Ubuntu):
status: New → Triaged
importance: Undecided → Wishlist
Revision history for this message
Clint Byrum (clint-fewbar) wrote :

I agree with Colin, I think you can replace the old call to dh_installinit with just a bare 'dh_installinit', and the upstart file (which appears to be named correctly) will be placed in the appropriate place. Then you don't have to change dovecot-common.dirs either.

Revision history for this message
Chuck Short (zulcss) wrote :

This has been added already.

chuck

Changed in dovecot (Ubuntu):
status: Triaged → Fix Released
Revision history for this message
doclist (dclist) wrote :

This patch seems to have broken dovecot job management. See Bug #646858.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.