uupdate should appends -0ubuntu1 instead of -1 to the version number

Bug #236526 reported by Guillaume Martres
4
Affects Status Importance Assigned to Milestone
devscripts (Debian)
Fix Released
Unknown
devscripts (Ubuntu)
Fix Released
Wishlist
Unassigned

Bug Description

Binary package hint: devscripts

Currently uupdate always appends -1 to the upstream version number, I'll attach a debdiff to fix this.

Related branches

Revision history for this message
Guillaume Martres (smarter) wrote :
Revision history for this message
Paul Sladen (sladen) wrote :

Two suggestions for slight improvements to that patch:

1. Define the "-1" or "-0ubuntu1" as a macro so that it only needs hard-coding in the script once.

2. Detect whether we are on Debian, or Ubuntu, and only switch to using the alternative postfix if we are on Ubuntu

With these, it should be possible to get the patch upstream into Debian and avoid carrying/maintaining the diff in the future.

Revision history for this message
Guillaume Martres (smarter) wrote :

Thanks for your comments, here is a new version of the patch which implements your suggestions.

Revision history for this message
Guillaume Martres (smarter) wrote :
Paul Sladen (sladen)
Changed in devscripts:
importance: Undecided → Wishlist
milestone: none → intrepid-alpha-1
status: New → Fix Released
Revision history for this message
Guillaume Martres (smarter) wrote :
Revision history for this message
Colin Watson (cjwatson) wrote :

Please don't hardcode the path to lsb_release; 'which lsb_release >/dev/null 2>&1' or 'type lsb_release >/dev/null 2>&1' (the former is more portable among shells Debian/Ubuntu, the latter is faster) is better than 'test -x /usr/bin/lsb_release'.

Changed in devscripts (Debian):
status: Unknown → New
Changed in devscripts (Debian):
status: New → Fix Committed
Changed in devscripts (Debian):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.