Failed to build on amd64

Bug #6546 reported by Phillip Susi
6
Affects Status Importance Assigned to Milestone
defrag (Ubuntu)
Fix Released
Medium
Unassigned

Bug Description

This package failed to build on amd64. I made several minor fixes and disabled the dpatch that prevents it from working on ext3 partitions, as I see no reason it shouldn't work on a cleanly unmounted ext3 partition. Will do some testing to verify that it works.

Attached is the .debdiff

Revision history for this message
Phillip Susi (psusi) wrote : defrag_0.73pjm1-7ubuntu1.debdiff

.

Revision history for this message
Phillip Susi (psusi) wrote :

This bug depends on bug #6542, but I can't figure out how to tell malone that.

Revision history for this message
SVAKSHA (svaksha) wrote :

Hello and thanks for the bug report.
As this bug depends on bug 6542, package : e2fsprogs, which has been assigned to a MOTU. Someone more knowledgeable may want to see if they can reproduce this problem with the latest Dapper source as the beta release is scheduled for next Thursday, 20060420 and we would like to fix bugs before the beta is publicized. -Thanks!

Revision history for this message
Zak B. Elep (zakame) wrote :

Does the problem still persists in Dapper?

Thanks,

Changed in defrag:
status: Unconfirmed → Needs Info
Revision history for this message
Phillip Susi (psusi) wrote :

I just tried building the package under edgy and it worked but is still only available on i386 according to packages.ubuntu.com. I'm not sure if it still failed to build on build-daemons, or if it has just been disabled on amd64. Actually, it looks like the binary is of the -7 version, but when I did an apt-get source defrag in edgy, it pulled -8. Was this package uploaded but not built for edgy for some reason?

Revision history for this message
Phillip Susi (psusi) wrote :

Sorry, my pbuilder environment was not up to date for edgy and so it was still using my patched e2fsprogs package. I built a clean pbuilder environment and it FTBS. Also checked launchpad and the -8 version that was auto synced to edgy from debian FTBS on build daemons for all architectures, so the last working i386 build for -7 in dapper is what is still in the archive for edgy.

I will see if I can get it building again.

Revision history for this message
Phillip Susi (psusi) wrote :

Updated the package with a dpatch to correct some warnings that caused build failure at least on i386. Will test on amd64 later tonight.

Revision history for this message
Phillip Susi (psusi) wrote :

Boy, I went to town with patches this time.

   * fix-ctime-warnings.dpatch: Fixes some warnings causing build failure
     and possibly incorrect behavior if time_t is not 32 bits
   * Disabled ext3-notwork.dpatch
   * handle-reserved-inodes.dpatch: Fixes a bug where reserved inodes
     ( like the ext3 journal inode ) would have their indirect blocks
     optimized but not saved, causing filesystem corruption
   * allow-ext3-journal-move.dpatch: Allows the data blocks of the ext3
     journal inode to be moved instead of treating them as fixed because
     it is a reserved inode
   * boost-pool-size.dpatch: Increases the default buffer size from 2 MB
     to 32 MB for better performance on modern machines

Revision history for this message
Phillip Susi (psusi) wrote :

Some slight modifications to fix corruption on new filesystems with the resize_inode feature.

   * fix-ctime-warnings.dpatch: Fixes some warnings causing build failure
     and possibly incorrect behavior if time_t is not 32 bits
   * Disabled ext3-notwork.dpatch
   * fix-indirect-blocks-for-fixed-inodes.dpatch: Marks indirect blocks
     belonging to fixed inodes as fixed. This fixes a bug that corrupted
     filesystems with reserved inodes, such as the ext3 journal.
   * allow-ext3-journal-move.dpatch: Allows the data blocks of the ext3
     journal inode to be moved instead of treating them as fixed because
     it is a reserved inode
   * boost-pool-size.dpatch: Increases the default buffer size from 2 MB
     to 32 MB for better performance on modern machines

Revision history for this message
Brandon Holtsclaw (imbrandon) wrote :

fixed the versioning from the patch and sponsored the upload, Phillip please keep an eye on this package to make sure there are no regressions

Changed in defrag:
status: Needs Info → Fix Committed
Revision history for this message
Vassilis Pandis (pandisv) wrote :

Can this bug be closed now ?

Revision history for this message
Phillip Susi (psusi) wrote :

What do you mean by closed? It has been marked as fix-committed.

Revision history for this message
Vassilis Pandis (pandisv) wrote :

As this appears to have hit the archives, shouldn't it be "fix released" ?

Changed in defrag:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.