Please add launcher quicklist for banshee

Bug #764321 reported by George Karavasilev
126
This bug affects 27 people
Affects Status Importance Assigned to Milestone
Ayatana Design
Invalid
Undecided
John Lea
Banshee
New
Wishlist
banshee (Ubuntu)
Triaged
Wishlist
Chow Loong Jin

Bug Description

Banshee does not have quicklist actions in Unity. The linked patch in comment #13 (attached in the upstream bug) is a preliminary patch towards resolving this issue, and will probably be the final patch assuming that the current set of quicklist actions added by the patch is acked and finalized.

For now, the list is:-
* Play
* Pause
* Stop
* Previous
* Next
* Preferences.

Play and Pause should probably be merged into Play/Pause using the banshee --toggle-playing option, as only one of those options is relevant at any point in time. However, while "Play" and "Pause" have already been localized by existing strings elsewhere, "Play/Pause" has not.

And do we need Preferences? Perhaps that action should be just dropped from the quicklist outright.

Revision history for this message
George Karavasilev (kokoto-java) wrote :

The .desktop files ;)

Revision history for this message
Bilal Akhtar (bilalakhtar) wrote :

Nice work, George!

As for Firefox, I've worked on it already at bug #741046, and as for Banshee, I'm changing the package bug to banshee as this isn't a bug in Unity.

affects: unity → banshee
Changed in banshee:
status: New → Confirmed
Revision history for this message
Bilal Akhtar (bilalakhtar) wrote :

In the future do keep in mind to open separate bugs for each quicklist you make :)

summary: - Launcher quicklists for the default apps are sucky
+ Please add launcher quicklist for banshee
Changed in banshee (Ubuntu):
status: New → In Progress
assignee: nobody → George Karavasilev (kokoto-java)
affects: banshee → null
Revision history for this message
Bilal Akhtar (bilalakhtar) wrote :

Oh, and you would also need a UI freeze exception. An example of such an exception request is bug #741046 .

Revision history for this message
George Karavasilev (kokoto-java) wrote :

Wishing I wasn't that much of a bug reporting noob :D Anyway I will make more quicklists for Banshee today and upload them here. As far as Firefox and bug https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/741046 if you want you can use my "Open a New Tab" quicklist if you're greenlit for implementing that. And one more thing, how do I fill this bug to be 'UI freeze exception'. P.S. I can do the bulgarian localization for Firefox and Banshee quicklists ASAP.
Now I'm of to make more quicklists for Banshee :P

Revision history for this message
George Karavasilev (kokoto-java) wrote :
description: updated
Revision history for this message
Bilal Akhtar (bilalakhtar) wrote :
Changed in null:
status: Confirmed → Opinion
status: Opinion → Invalid
Revision history for this message
Matt Sturgeon (mattsturgeon) wrote :

Added upstream bug-link.

Note if you guys want this in Natty, you'll have to do it as an Ubuntu-specific patch for now, as no new Banshee stable will be coming out by the 28th.

I'm sure the Banshee crowd will accept any patches at a later date (before their next release) :-)

tags: added: patch
Changed in banshee:
importance: Unknown → Medium
status: Unknown → New
Revision history for this message
Chow Loong Jin (hyperair) wrote :

Thanks for the desktop files, but please attach them separately next time. It's such a pain to break open each tarball to see what you're talking about, you know?

Revision history for this message
Chow Loong Jin (hyperair) wrote :

Do we have guys from Unity subscribed here who can verify if the amended desktop files are correct? I've never seen a desktop file looking like that before. A link to some specification of quicklists somewhere would be nice.

Revision history for this message
George Karavasilev (kokoto-java) wrote :

Sorry about the attachment complication, next time I will attach the .desktop files and the screenshot separately ;)
And the is only one .dektop file in the tarball - banshee.desktop, I dropped the Firefox quicklist thing due to the fact that there is already such a bug and Bilal Akhtar is his 'fixer'.
As far as testing goes I've tested it on two machines runing the latest and greatest Unity and Banshee quicklists work like a charm (screenshots included at the tarball), the .desktop file is strange, because quicklist syntax is bit different from an ordinary .desktop file syntax. Here is the included stuff in the .desktop file:
X-Ayatana-Desktop-Shortcuts=Play;Pause;Stop;Previous;Next;Preferences

[Play Shortcut Group]
Name=Play
Name[bg]=Изпълнение
Exec=banshee --play
TargetEnvironment=Unity

[Pause Shortcut Group]
Name=Pause
Name[bg]=Паузиране
Exec=banshee --pause
TargetEnvironment=Unity

[Stop Shortcut Group]
Name=Stop
Name[bg]=Спиране
Exec=banshee --stop
TargetEnvironment=Unity

[Previous Shortcut Group]
Name=Previous
Name[bg]=Предишна
Exec=banshee --previous
TargetEnvironment=Unity

[Next Shortcut Group]
Name=Next
Name[bg]=Следваща
Exec=banshee --next
TargetEnvironment=Unity

[Preferences Shortcut Group]
Name=Preferences
Name[bg]=Настройки
Exec=banshee --show-preferences
TargetEnviroment=Unity

Hoping I've cleared things up ;) If you have any recomendations to be added to the quicklists I'm listening :)

Revision history for this message
Chow Loong Jin (hyperair) wrote : Re: [Bug 764321] Re: Please add launcher quicklist for banshee

Alright, at this point, I have a few questions:-

1. Are we sure that these are the quicklist actions we want to have for Banshee?
2. Is it too late in the cycle for including this? I can come up with a patch
for this pretty quickly, I reckon.
3. Do we have all the required strings in banshee.mo for translating the
quicklists properly?

For #1, I'm subscribing Conor as he would probably have a good idea about what
we should or should not add.

  subscribe cjcurran

--
Kind regards,
Loong Jin

Changed in banshee (Ubuntu):
assignee: George Karavasilev (kokoto-java) → Chow Loong Jin (hyperair)
Revision history for this message
Chow Loong Jin (hyperair) wrote :
summary: - Please add launcher quicklist for banshee
+ [FFe] Please add launcher quicklist for banshee
description: updated
description: updated
description: updated
Revision history for this message
George Karavasilev (kokoto-java) wrote : Re: [FFe] Please add launcher quicklist for banshee

@Chow Loong Jin:
For #1 - I have added the most needed stuff - Play, Pause, Stop, Previous, Next, Preferences, but still if anyone has something to add/change he/she is more than welcome.
For #2 - It is kinda too late for Natty release cycle, because of the UI freeze, but still this bug can be added as exception and @Bilal Akhtar has provided a "how-to" : https://wiki.ubuntu.com/FreezeExceptionProcess#UserInterfaceFreeze%20Exceptions
For #3 - Not sure if we have all the localization strings.

Revision history for this message
Scott Kitterman (kitterman) wrote :

Nack on FFe for Natty. It's too late. Unsubscribing the release team.

Changed in banshee (Ubuntu):
milestone: none → oneiric-alpha-1
Omer Akram (om26er)
summary: - [FFe] Please add launcher quicklist for banshee
+ Please add launcher quicklist for banshee
Victor Vargas (kamus)
Changed in banshee (Ubuntu):
importance: Undecided → Medium
Changed in banshee (Ubuntu):
milestone: oneiric-alpha-1 → oneiric-alpha-2
Revision history for this message
John Lea (johnlea) wrote :

Marked as invalid because the quicklist should not be used to replicate the functionality found in the Sound Indicator.

However I am sure Banshee could use a quicklist; any suggestions for functionality beyond transport controls?

Changed in ayatana-design:
assignee: nobody → John Lea (johnlea)
status: New → Invalid
Martin Pitt (pitti)
Changed in banshee (Ubuntu):
milestone: oneiric-alpha-2 → oneiric-alpha-3
Changed in banshee (Ubuntu):
milestone: oneiric-alpha-3 → ubuntu-11.10-beta-2
milestone: ubuntu-11.10-beta-2 → natty-updates
milestone: natty-updates → ubuntu-11.10-beta-1
Martin Pitt (pitti)
Changed in banshee (Ubuntu):
milestone: ubuntu-11.10-beta-1 → ubuntu-11.10-beta-2
Dave Walker (davewalker)
Changed in banshee (Ubuntu):
milestone: ubuntu-11.10-beta-2 → ubuntu-11.10
Revision history for this message
Γουργιώτης Γιώργος (aka Gourgi) (gourgi) wrote :

how about having rating options in the quicklist?

Changed in banshee (Ubuntu):
milestone: ubuntu-11.10 → none
Curtis Hovey (sinzui)
no longer affects: null
Changed in banshee:
importance: Medium → Wishlist
Revision history for this message
Izidor Matušov (izidor) wrote :

Bump. What is the status of this bug?

John > I am not sure about replacing the indicator, it would provide another way how to accomplish a desired action. It is much more quicker and easier to navigate to launcher and use quicklist because the banshee icon is more larger there than looking for sound indicator.

papukaija (papukaija)
tags: added: desktop-file
Changed in banshee (Ubuntu):
importance: Medium → Wishlist
status: In Progress → Triaged
Revision history for this message
Doug McMahon (mc3man) wrote :

This is an odd bug, the idea that Banshee can't have transport controls in a quicklist because they exist in sound menu doesn't make sense in light of rhythmbox having those controls in in it's quicklist.
So it would seen the Design comment could be ignored

Revision history for this message
Amr Ibrahim (amribrahim1987) wrote :

Banshee is community maintained, adding launcher quicklist for Banshee does not really concern the Unity Design team. Besides, I agree with Doug McMahon, Rhythmbox have both controls in its quicklist and the sound indicator.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.