armel build failure (uses internal outdated libffi)

Bug #635415 reported by Matthias Klose
14
This bug affects 1 person
Affects Status Importance Assigned to Milestone
plt-scheme (Ubuntu)
Fix Released
Undecided
Jani Monoses

Bug Description

Binary package hint: plt-scheme

package should use the system libffi

http://launchpadlibrarian.net/52476462/buildlog_ubuntu-maverick-armel.plt-scheme_4.2.4-2_FAILEDTOBUILD.txt.gz

/bin/bash ./libtool --mode=compile gcc -I. -I/build/buildd/plt-scheme-4.2.4/src/foreign/gcc/libffi/include -Iinclude -I/build/buildd/plt-scheme-4.2.4/src/foreign/gcc/libffi/src -g -c -o src/arm/sysv.lo /build/buildd/plt-scheme-4.2.4/src/foreign/gcc/libffi/src/arm/sysv.S
libtool: compile: gcc -I. -I/build/buildd/plt-scheme-4.2.4/src/foreign/gcc/libffi/include -Iinclude -I/build/buildd/plt-scheme-4.2.4/src/foreign/gcc/libffi/src -g -c /build/buildd/plt-scheme-4.2.4/src/foreign/gcc/libffi/src/arm/sysv.S -fPIC -DPIC -o src/arm/.libs/sysv.o
/build/buildd/plt-scheme-4.2.4/src/foreign/gcc/libffi/src/arm/sysv.S: Assembler messages:
/build/buildd/plt-scheme-4.2.4/src/foreign/gcc/libffi/src/arm/sysv.S:202: Error: selected processor does not support ARM mode `stfeqs f0,[r2]'
/build/buildd/plt-scheme-4.2.4/src/foreign/gcc/libffi/src/arm/sysv.S:207: Error: selected processor does not support ARM mode `stfeqd f0,[r2]'
/build/buildd/plt-scheme-4.2.4/src/foreign/gcc/libffi/src/arm/sysv.S:282: Error: selected processor does not support ARM mode `ldfs f0,[sp]'
/build/buildd/plt-scheme-4.2.4/src/foreign/gcc/libffi/src/arm/sysv.S:285: Error: selected processor does not support ARM mode `ldfd f0,[sp]'
/build/buildd/plt-scheme-4.2.4/src/foreign/gcc/libffi/src/arm/sysv.S:288: Error: selected processor does not support ARM mode `ldfd f0,[sp]'
make[9]: *** [src/arm/sysv.lo] Error 1
make[9]: Leaving directory `/build/buildd/plt-scheme-4.2.4/build/foreign/gcc/libffi'
make[8]: *** [gcc/libffi/libffi.la] Error 2

Matthias Klose (doko)
Changed in plt-scheme (Ubuntu):
assignee: nobody → Oliver Grawert (ogra)
Oliver Grawert (ogra)
Changed in plt-scheme (Ubuntu):
assignee: Oliver Grawert (ogra) → David Sugar (dyfet)
tags: added: ftbfs
Revision history for this message
David Sugar (dyfet-deactivatedaccount) wrote :

I do have a simple patch for this, attached...

Changed in plt-scheme (Ubuntu):
assignee: David Sugar (dyfet) → nobody
Revision history for this message
Michael Casadevall (mcasadevall) wrote :

Requesting freeze exception to upload as we're past RC and final freeze to upload FTBFS resolivng bug. Changes are ARM specific, and will not interfere on any other architecture. No code changes.

Revision history for this message
Iulian Udrea (iulian) wrote :

I wonder why you subscribed motu-release. It's ubuntu-release these days...

Revision history for this message
Iulian Udrea (iulian) wrote :

Approved. Please upload.

Changed in plt-scheme (Ubuntu):
status: New → Confirmed
Revision history for this message
Steve Langasek (vorlon) wrote :

N.B.: as a bug fix to an unseeded universe package, this doesn't require a freeze exception at all, you can just upload to the queue.

Revision history for this message
Scott Kitterman (kitterman) wrote : Re: [Bug 635415] Re: armel build failure (uses internal outdated libffi)

As discussed, no FFe needed.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package plt-scheme - 4.2.4-2ubuntu1

---------------
plt-scheme (4.2.4-2ubuntu1) maverick; urgency=low

  * Use -mfloat-abi=soft for thumb2 assembler (LP: #635415)
 -- David Sugar <email address hidden> Fri, 01 Oct 2010 14:00:26 +0000

Changed in plt-scheme (Ubuntu):
status: Confirmed → Fix Released
Revision history for this message
Matthias Klose (doko) wrote :

the patch is wrong. it works around a bug in libffi, which is both fixed upstream and in the Ubuntu package. so either fix the copy of libffi, or use the system libffi.

Changed in plt-scheme (Ubuntu):
status: Fix Released → Confirmed
Steve Langasek (vorlon)
Changed in plt-scheme (Ubuntu):
assignee: nobody → David Sugar (dyfet)
Revision history for this message
David Sugar (dyfet-deactivatedaccount) wrote :

There are specific reasons the patch was done the way it was:

First, it did not make sense to modify in any way the build of plt-scheme on other architectures this close to release. We would have had to rebuild all packages dependent on it, and verify they were not broken as a result of such a change like the one originally proposed to change the linkage and use an external instance of libffi. Hence, I sought a change that only effects and resolves the issue for armel without risking effecting the builds on any other architecture.

Second, because of the way libtool works, it strips out most cflags options when compiling .S files. For this reason, the only clear way to force feed the necessary option from the debian rules was to override CC itself.

Revision history for this message
David Sugar (dyfet-deactivatedaccount) wrote :

Finally, the package is being renamed and redone in Natty, as happened in Debian. Upstream renamed itself rachet starting with 5.0. Hence, my original patch, or any patch, has a short shelf life. The goal was to avoid having to do SRU's just because of armel for Maverick, and not to change the way this and dependent packages are built or linked on the other architectures in Maverick.

tags: added: patch
Revision history for this message
Loïc Minier (lool) wrote :

I couldn't find a "rachet" package; does it change anything what the name of the package is? I expect the packaging will be moved to the new name, just like this bug

Revision history for this message
David Sugar (dyfet-deactivatedaccount) wrote :

It is also an entirely new baseline upstream release (5.0) as well as a rename. This patch may still apply under the new name, but when it happens all the dependent packages will also have to be rebuilt anyway, so that is when it would make sense to change it to use the external libffi and play with linking or otherwise playing with it, assuming the 5.x upstream still bundles it's own local libffi.

Tobin Davis (gruemaster)
Changed in plt-scheme (Ubuntu):
assignee: David Sugar (dyfet) → Jani Monoses (jani)
Revision history for this message
Jani Monoses (jani) wrote :

a fix was copied from libffi, and the previous change undone.

Changed in plt-scheme (Ubuntu):
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.