add DKMS to Ubuntu

Matt,

dget http://linux.dell.com/dkms/debian/dkms_2.0.17-1.dsc
dpkg-source -x dkms_2.0.17-1.dsc
gpg: Signature made Fri Jun 22 04:45:47 2007 UTC using DSA key ID 23B66A9D
gpg: Can't check signature: public key not found
dpkg-source: error: syntax error in source control file ./dkms_2.0.17-1.dsc at line 14: expected blank line before PGP signature

I tried with both Feisty and Gutsy devscripts. Is there really something wrong with the dsc file?

I was able to generate source and debs from the git repo.

Package uploaded to REVU for review and comment.

http://revu.tauware.de/details.py?upid=189

If you have trouble uploading to REVU, you can also use http://help.launchpad.net/PPAQuickStart

Found the new package at: http://revu.tauware.de/details.py?upid=228

What I found in the packaging:
 - dkms (2.0.17.2-1) unstable; urgency=low should rather be dkms (2.0.17.2-0ubuntu1) gutsy; urgency=low
 - add a (LP: #121676) to the changelog, so the bug gets closed automatically (https://wiki.ubuntu.com/ClosingBugsFromChangelog)
 - for the Maintainer field you should follow https://wiki.ubuntu.com/DebianMaintainerField

lintian warnings:
W: dkms source: debian-rules-ignores-make-clean-error line 48
N:
N: A rule in the debian/rules file for this package calls the package's
N: clean or distclean target with a line like:
N:
N: -$(MAKE) distclean
N:
N: The leading - tells make to ignore all errors. Normally this is done
N: for packages using Autoconf since Makefile may not exist. However,
N: this line ignores all other error messages, not just the missing
N: Makefile error. It's better to use:
N:
N: [ ! -f Makefile ] || $(MAKE) distclean
N:
N: so that other error messages from the clean or distclean rule will
N: still be caught.
N:
W: dkms: script-not-executable ./etc/dkms/template-dkms-mkdeb/debian/postinst
N:
N: This file starts with the #! sequence that marks interpreted scripts,
N: but it is not executable.
N:
W: dkms: script-not-executable ./etc/dkms/template-dkms-mkdeb/debian/postrm
W: dkms: script-not-executable ./etc/dkms/template-dkms-mkdeb/debian/prerm
W: dkms: script-not-executable ./etc/dkms/template-dkms-mkdeb/debian/rules

Daniel, thanks for your review. I've addressed most of these points (except the warning: script-not-executable as these get dealt with separately and as templates I don't want them executed on the system). I've uploaded http://revu.tauware.de/details.py?upid=251 which is dkms_2.0.17.3-0ubuntu1 for further review.

Thanks,
Matt

I assume pkg/ and linux-meta* were not supposed to land in that tarball?

Do you intend to install stuff to these places:

drwxr-xr-x root/root 0 2007-09-17 11:59 ./etc/dkms/template-dkms-mkdeb/
drwxr-xr-x root/root 0 2007-09-17 11:59 ./etc/dkms/template-dkms-mkdeb/debian/
-rw-r--r-- root/root 857 2007-06-21 21:51 ./etc/dkms/template-dkms-mkdeb/debian/rules
-rw-r--r-- root/root 150 2007-06-21 21:51 ./etc/dkms/template-dkms-mkdeb/debian/README.Debian
-rw-r--r-- root/root 8 2007-06-21 21:51 ./etc/dkms/template-dkms-mkdeb/debian/dirs
-rw-r--r-- root/root 2267 2007-06-21 21:51 ./etc/dkms/template-dkms-mkdeb/debian/postinst
-rw-r--r-- root/root 136 2007-06-21 21:51 ./etc/dkms/template-dkms-mkdeb/debian/changelog
-rw-r--r-- root/root 287 2007-06-21 21:51 ./etc/dkms/template-dkms-mkdeb/debian/control
-rw-r--r-- root/root 2 2007-06-21 21:51 ./etc/dkms/template-dkms-mkdeb/debian/compat
-rw-r--r-- root/root 70 2007-06-21 21:51 ./etc/dkms/template-dkms-mkdeb/debian/copyright
-rw-r--r-- root/root 360 2007-06-21 21:51 ./etc/dkms/template-dkms-mkdeb/debian/prerm
-rw-r--r-- root/root 478 2007-06-21 21:51 ./etc/dkms/template-dkms-mkdeb/debian/postrm
-rw-r--r-- root/root 127 2007-06-21 21:51 ./etc/dkms/template-dkms-mkdeb/Makefile

?

no, linux-meta is not supposed to be in there. pkg/ either. I'll clean that up, it's just an upload bug.

As for everything under /etc/dkms/template-dkms-mkdeb/, yes, that's to be there. DKMS uses the code in that directory to generate DKMSified kernel module packages as debs, with its internal 'dkms mkdeb' command.

I removed the linux-meta* files from the orig tarball, and uploaded a new copy. pkg/ remains in the original tarball, as I want that distributed as part of the upstream package.

I'm happy with the packaging: +1.

With another +1 (maybe from the Kernel team), this package should go through https://wiki.ubuntu.com/FreezeExceptionProcess#head-c9d177822a71b90ec5fb703ed0d0f30eeb8fc1db (as we're in New Package Freeze already).

+1

We really need this package so that third-parties can easily package kernel modules without worrying about ABI bumps post release (e.g. security updates)

The MOTU-UVF team needs to give its OK now.

+1 from me

+1, please go ahead and upload.

Uploaded. Thank you for your contribution.

Per Scott's Kitterman comments on 9/19, thank you.

The bug task for the somerville project has been removed by an automated script. This bug has been cloned on that project and is available here: https://bugs.launchpad.net/bugs/1306154