sync-source should not assume 0 is the lowest version number possible
Bug #89150 reported by
Tollef Fog Heen
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Undecided
|
James Westby | ||
Bug Description
Sync-source assumes that 0 is the lowest version number possible:
lp_archive@
07:13:01 DEBUG Acquiring lock
07:13:01 DEBUG Initialising connection.
Getting binaries for feisty...
[Nothing to update] blktrace (0 [ubuntu] >= 0~git-200612211
0~ is less than 0, and it should probably assume "" is the lowest version (since it's not a legal version and ~ alone is probably not a legal version either.
Related branches
lp:~james-w/launchpad/sync-source-negative-versions
- Graham Binns (community): Approve (code)
-
Diff: 48 lines (+8/-5)2 files modifiedlib/lp/soyuz/scripts/tests/test_sync_source.py (+2/-2)
scripts/ftpmaster-tools/sync-source.py (+6/-3)
| Changed in soyuz: | |
| status: | New → In Progress |
| assignee: | nobody → James Westby (james-w) |
Revision history for this message
| Ursula Junque (ursinha) wrote Bug fixed by a commit | #1 |
| Changed in soyuz: | |
| milestone: | none → 10.03 |
| status: | In Progress → Fix Committed |
| tags: | added: qa-needstesting |
Revision history for this message
| Curtis Hovey (sinzui) wrote Bug 89150 Fix released | #2 |
| Changed in soyuz: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in stable r10468 <http://