Uploads with extra data in the .tar.gz rejected unnecessarily

Bug #637507 reported by James Westby
20
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Jelmer Vernooij

Bug Description

Hi,

Launchpad suffers from a problem that many of us python programmers who
work with Debian packages suffered from.

Colin does a good summary of the problem here:

  http://www.chiark.greenend.org.uk/ucgi/~cjwatson/blosxom/2009-07-02-python-sigpipe.html

and William here:

  https://bugs.edge.launchpad.net/ubuntu/+source/bzr-builddeb/+bug/399938/comments/7

There are a fair number of packages that have this issue, which presumably hit on the
Lucid upgrade.

The fix is very simple.

Thanks,

James

Related branches

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

confirmed, got it there too.

Changed in soyuz:
status: New → Confirmed
Revision history for this message
Julian Edwards (julian-edwards) wrote : Re: [Bug 637507] [NEW] Uploads with extra data in the .tar.gz rejected unnecessarily

Can you post an example of something that breaks please - is it reproducible?
I haven't got much to go on here in terms of testing.

Thanks.

Revision history for this message
Ken VanDine (ken-vandine) wrote :

This tarball had failed for me, I had to extract it and recreate in order to upload:

http://edge.launchpad.net/dbusmenu/0.3/0.3.13/+download/libdbusmenu-0.3.13.tar.gz

And I think the tarball Didier had problems with was:

http://ftp.gnome.org/pub/GNOME/sources/gnome-bluetooth/2.31/gnome-bluetooth-2.31.90.tar.gz

Changed in soyuz:
importance: Undecided → High
status: Confirmed → Triaged
assignee: nobody → Jelmer Vernooij (jelmer)
tags: added: boobytrap soyuz-upload
Revision history for this message
James Westby (james-w) wrote :

On Mon, 13 Sep 2010 19:36:11 -0000, James Westby <email address hidden> wrote:
> Public bug reported:
>
> Hi,
>
> Launchpad suffers from a problem that many of us python programmers who
> work with Debian packages suffered from.
>
> Colin does a good summary of the problem here:
>
> http://www.chiark.greenend.org.uk/ucgi/~cjwatson/blosxom/2009-07-02
> -python-sigpipe.html
>
> and William here:
>
> https://bugs.edge.launchpad.net/ubuntu/+source/bzr-
> builddeb/+bug/399938/comments/7
>
> There are a fair number of packages that have this issue, which presumably hit on the
> Lucid upgrade.
>
> The fix is very simple.

Oh, and it's worth looking at anywhere that you call subprocess, as they
can suffer from the same thing. I can't say that making this change is
always the correct thing to do, but it may prevent some bugs in the
future.

Thanks,

James

Jelmer Vernooij (jelmer)
Changed in soyuz:
milestone: none → 10.10
Changed in soyuz:
milestone: 10.10 → none
status: Triaged → In Progress
Revision history for this message
Launchpad QA Bot (lpqabot) wrote : Bug fixed by a commit
Changed in soyuz:
milestone: none → 10.11
tags: added: qa-needstesting
Changed in soyuz:
status: In Progress → Fix Committed
Revision history for this message
Robert Collins (lifeless) wrote :

Marking QA-ok because the test suite is a sufficient check of this code path.

tags: added: qa-ok
removed: qa-needstesting
Revision history for this message
Robert Collins (lifeless) wrote :

We've deployed this to loganberry and the appservers. Does it need a wider deploy to be fixed?

Revision history for this message
Julian Edwards (julian-edwards) wrote :

Yes - archiveuploader and archivepublisher use subprocesses, so this needs to go to all soyuz machines (apart from cesium as we're blocked on me fixing that buildd-manager snafu)

Curtis Hovey (sinzui)
Changed in soyuz:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.