BuilderSet.getBuildQueueSizes needs to consider virtualized=NULL as false
Bug #609904 reported by
William Grant
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Julian Edwards | ||
Bug Description
Translation template jobs are currently created with virtualized=NULL. Although this is arguably a situation that we should forbid, it is currently permissible. But BuilderSet.
virt_str = 'virt' if virtualized else 'nonvirt'
That places virtualized=NULL builds in the non-virt queue size estimate, when they in fact build on the virtual builders.
Related branches
lp:~julian-edwards/launchpad/build-queue-sizes-bug-609904
- Māris Fogels (community): Approve (code)
-
Diff: 75 lines (+28/-5)2 files modifiedlib/lp/buildmaster/doc/builder.txt (+21/-1)
lib/lp/buildmaster/model/builder.py (+7/-4)
| Changed in soyuz: | |
| status: | New → Triaged |
| importance: | Undecided → High |
| tags: | added: buildfarm |
| Changed in soyuz: | |
| status: | Triaged → In Progress |
| assignee: | nobody → Julian Edwards (julian-edwards) |
| Changed in soyuz: | |
| status: | In Progress → Fix Committed |
| tags: | added: qa-ok |
| Changed in soyuz: | |
| milestone: | none → 10.08 |
Revision history for this message
| Ursula Junque (ursinha) wrote Bug fixed by a commit | #1 |
| tags: |
added: qa-needstesting removed: qa-ok |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in soyuz: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in stable r11289 <http://