Launchpad itself

Cannot accept package which closes inaccessible bug

Bug #564491 reported by William Grant
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Julian Edwards
Launchpad itself 10.10

Bug Description

ScottK cannot accept rootstock from Lucid UNAPPROVED. This is because its changelog references bug #540822, which he does not have access to.

 * Module lp.soyuz.scripts.processaccepted, line 152, in close_bugs_for_sourcepackagerelease
   edited_task = bug.setStatus(
 Unauthorized: (<Bug at 0x13580f90>, 'setStatus', 'launchpad.Edit')<br />

Related branches

lp:~julian-edwards/launchpad/queue-accept-with-private-bugs
Deryck Hodge (community): Approve (code)
Tim Penhey (community): Approve (mentor)
Steve Kowalik (community): Approve (code*)
Robert Collins: Pending (code) requested
Diff: 167 lines (+62/-3)
3 files modified
lib/lp/soyuz/scripts/processaccepted.py (+10/-0)
lib/lp/soyuz/scripts/tests/test_queue.py (+50/-2)
lib/lp/testing/factory.py (+2/-1)
Revision history for this message
Scott Kitterman (kitterman) wrote :

Nice detective work. Thanks.

Revision history for this message
Julian Edwards (julian-edwards) wrote :

Yes, very, thanks William.

I'm not sure what we can do about this in the short term other than to try and present an error on the queue page.

Changed in soyuz:
status: New → Triaged
importance: Undecided → Medium
tags: added: queue-page ui
tags: added: oops
Revision history for this message
Julian Edwards (julian-edwards) wrote :

Just had a call with Deryck and he suggested that we make the bug closing asynchronous via a Job. This is good because:

1) it would fix this immediate problem as the job runner is zopeless and thus is not restricted by the security
2) the page will time out sometimes because it has a lot of email notifications to send if it closes many bugs at once. Doing these asynchronously would make the page much faster.

Based on the fact that the same code that is blowing up here is also called in zopeless mode when the package gets auto-accepted I'd ok with using removeSecurityProxy() on that specific call on the strict understanding that it's temporary until we get a Job set up.

Changed in soyuz:
milestone: none → pending
importance: Medium → High
Revision history for this message
Julian Edwards (julian-edwards) wrote :

See also bug 566339

Julian Edwards (julian-edwards)
Changed in soyuz:
status: Triaged → In Progress
Revision history for this message
Launchpad QA Bot (lpqabot) wrote : Bug fixed by a commit

Fixed in stable r11556 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/11556>.

Changed in soyuz:
assignee: nobody → Julian Edwards (julian-edwards)
milestone: pending → 10.10
tags: added: qa-needstesting
Changed in soyuz:
status: In Progress → Fix Committed
Revision history for this message
Steve Kowalik (stevenk) wrote :

I have QA'd this change on dogfood by creating a package which references the bug in the original report, and accepting it via the web interface, which did not OOPS.

tags: added: qa-ok
removed: qa-needstesting
Curtis Hovey (sinzui)
Changed in soyuz:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.