Launchpad itself

The archive +admin page's checkbox for using ARM should present checkboxes for all restricted architectures

Bug #531302 reported by Muharem Hrnjadovic
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Medium
Jelmer Vernooij
Launchpad itself 10.07

Bug Description

Related to bug #471148, the archive +admin page merely features a single check-box allowing the archive administrator to override the 'restricted' flag for the 'arm' processor family.

This should be turned into a full-blown UI element facilitating the association/disassociation with/from any restricted processor family. that

Related branches

lp:~jelmer/launchpad/594237-arm-checkbox
Leonard Richardson (community): Approve
Diff: 299 lines (+97/-54)
8 files modified
lib/lp/soyuz/browser/archive.py (+29/-1)
lib/lp/soyuz/configure.zcml (+2/-1)
lib/lp/soyuz/interfaces/archive.py (+6/-2)
lib/lp/soyuz/interfaces/processor.py (+6/-0)
lib/lp/soyuz/model/archive.py (+18/-33)
lib/lp/soyuz/model/processor.py (+5/-0)
lib/lp/soyuz/tests/test_archive.py (+21/-17)
lib/lp/soyuz/tests/test_processor.py (+10/-0)
Muharem Hrnjadovic (al-maisan)
tags: added: arm ppa ui
Julian Edwards (julian-edwards)
summary: - Facilitate the (dis-)association between archives and restricted
- processor families
+ The archive +admin page's checkbox for using ARM should present
+ checkboxes for all restricted architectures
Revision history for this message
Julian Edwards (julian-edwards) wrote :

For example. see

https://answers.edge.launchpad.net/people/+me/+editlanguages

as a page that uses a multi checkbox widget.

Changed in soyuz:
status: New → Triaged
importance: Undecided → Medium
tags: added: buildfarm
Jelmer Vernooij (jelmer)
Changed in soyuz:
status: Triaged → In Progress
assignee: nobody → Jelmer Vernooij (jelmer)
Revision history for this message
Ursula Junque (ursinha) wrote : Bug fixed by a commit

Fixed in stable r11078 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/11078>.

tags: added: qa-needstesting
Changed in soyuz:
status: In Progress → Fix Committed
Ursula Junque (ursinha)
Changed in soyuz:
milestone: none → 10.07
Revision history for this message
Jelmer Vernooij (jelmer) wrote :

While QA'ing I noticed that the checkboxes list does not go away if there are no restricted architectures. This is a bug, though we're unlikely to ever run into it since ARM is going to be marked as restricted. It's also just cosmetic. I'm not sure where to best fix this. Either the form should not include the enabled_restricted_architectures field at all if there are no restricted architectures, or the LabeledMultiCheckBox widget should hide itself if its vocabulary is empty.

Jelmer Vernooij (jelmer)
tags: added: qa-okish
removed: qa-needstesting
Revision history for this message
Julian Edwards (julian-edwards) wrote :

One of the problems with this approach is that we might want to mark a PPA as ok to use an arch before it's marked restricted. This is not a problem for now though.

Curtis Hovey (sinzui)
Changed in soyuz:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.