Publisher configuration needs redesign

Since we sort the design, some tests which have hardcoded archive path need to be revisited and fixed, they are, for instance, doc/soyuz-upload.txt and scripts/ftest/test_ftpmaster.py (there are other)

The configuration is per distribution and per distrorelease. We should not expect it to be in the launchpad.conf

By all means make it an XML configuration blob which its in the column in the DB.

Alternatively we can just use proper columns instead of a nasty text field.

Daniel Silverstone wrote:
> The configuration is per distribution and per distrorelease. We should
> not expect it to be in the launchpad.conf

Gina already does it, however I agree that gina works in a more
controlled environment than the distro/distrorelease.

> By all means make it an XML configuration blob which its in the column
> in the DB.

XML & config represent the same issue, I don't think people would be
able to edit/fine-tune it in place.

> Alternatively we can just use proper columns instead of a nasty text
> field.

Could be, but anyway we don't need that bunch of attributes in the DB.

See an example of IDistribution.lucilleconfig

[publishing]
pendingremovalduration=5
root=/var/tmp/archive
archiveroot=/var/tmp/archive/ubuntutest
poolroot=/var/tmp/archive/ubuntutest/pool
distsroot=/var/tmp/archive/ubuntutest/dists
overrideroot=/var/tmp/archive/ubuntutest-overrides
cacheroot=/var/tmp/archive/ubuntutest-cache
miscroot=/var/tmp/archive/ubuntutest-misc

The only attribute we need in IDistribution is the
pendingremovalduration, which could also defaults to a zope config value.

'root' sounds like a machine dependendent value to me and should fit in
the zope config as well, local_archive_path.

Maybe we still need to handle specific publication paths fo each
distribuiton (mirroring and permission issues), so, I'd not mind to have
 an IDistribution.archive_path, which would be joined with
local_archive_path to build former 'root'.

And then a set of path.join s for poolroot, distroot, overrideroot,
cacheroot and miscroot, which could also be provided as properties in
IDistribution. I can't see any use-case for customized cache/misc/pool.

And the IDistroRelease.lucilleconfig:

[publishing]
components = main restricted universe multiverse

Isn't it the same as IDistroRelease.components() ?

[]
--
Celso Providelo <email address hidden>
Canonical Ltd - http://www.canonical.com

Paths will now be calculated from archivepublisher.root, components from ComponentSelection, and the stay of execution from a new config key.

On Fri, Oct 15, 2010 at 10:32 PM, William Grant <email address hidden> wrote:
> Paths will now be calculated from archivepublisher.root, components from
> ComponentSelection, and the stay of execution from a new config key.

Stay of execution? If thats just 'how long to keep things' I suggest
using a flag for it, with a hard coded fallback.

On Friday 15 October 2010 10:56:01 you wrote:
> On Fri, Oct 15, 2010 at 10:32 PM, William Grant <email address hidden>
wrote:
> > Paths will now be calculated from archivepublisher.root, components from
> > ComponentSelection, and the stay of execution from a new config key.
>
> Stay of execution? If thats just 'how long to keep things' I suggest
> using a flag for it, with a hard coded fallback.

Given that we've never changed it, I say just hard-code it.

Fixed in db-stable r10086 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/db-stable/revision/10086>.