Launchpad itself

gc.get_objects() interacts badly with bzrlib lazy imports

Bug #618987 reported by Tim Penhey
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Tim Penhey
Launchpad itself 10.09 "Hungry Hippo"

Bug Description

The lp.translations.scripts.tests.test_message_sharing_migration.TestSharingMigrationPerformance test uses gc.get_objects() in an approximation to determine whether or not the message sharing script loads POMsgId or POTemplate objects.

A better way is to use a storm statement tracer and check the queries.

Related branches

lp:~thumper/launchpad/fix-TestSharingMigrationPerformance
Robert Collins (community): Approve
Diff: 114 lines (+29/-61)
1 file modified
lib/lp/translations/scripts/tests/test_message_sharing_migration.py (+29/-61)
Revision history for this message
Tim Penhey (thumper) wrote :

This was blocking landing bzr 2.2

Revision history for this message
Launchpad QA Bot (lpqabot) wrote : Bug fixed by a commit

Fixed in stable r11363 (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/11363) by a commit, but not testable.

tags: added: qa-untestable
Revision history for this message
Tim Penhey (thumper) wrote : Re: [Bug 618987] Re: gc.get_objects() interacts badly with bzrlib lazy imports

On Wed, 18 Aug 2010 19:31:14 you wrote:
> Fixed in stable r11363 (http://bazaar.launchpad.net/~launchpad-
> pqm/launchpad/stable/revision/11363) by a commit, but not testable.
>
> ** Tags added: qa-untestable

I used the no-qa tag as there was no need to qa this, not that it is
untestable. If the tests all pass, we are good, and this is qa-ok.

Revision history for this message
Robert Collins (lifeless) wrote :

>> Fixed in stable r11363 (http://bazaar.launchpad.net/~launchpad-
>> pqm/launchpad/stable/revision/11363) by a commit, but not testable.
>>
>> ** Tags added: qa-untestable
>
> I used the no-qa tag as there was no need to qa this, not that it is
> untestable.  If the tests all pass, we are good, and this is qa-ok.

Right - thats what qa-untestable means : automated tests are green (or
it wouldn't be in stable) and no qa testing can be done (because it
has no visible-or-pokable-at-aspects).

-Rob

Данило Шеган (danilo)
Changed in rosetta:
status: In Progress → Fix Committed
Curtis Hovey (sinzui)
Changed in rosetta:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.