Launchpad itself

Retrieve TranslationTemplatesBuildJob results

Bug #507678 reported by Jeroen T. Vermeulen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Jeroen T. Vermeulen
Launchpad itself 10.02

Bug Description

The build-farm jobs that generate translation templates for branches should retrieve the generated files from the slave and make them available for server-side processing.

Related branches

lp:~jtv/launchpad/bug-507678
Eleanor Berger (community): Approve (code)
Diff: 715 lines (+431/-98)
9 files modified
lib/devscripts/ec2test/tests/test_ec2instance.py (+17/-59)
lib/lp/buildmaster/model/buildfarmjobbehavior.py (+15/-4)
lib/lp/buildmaster/tests/test_buildfarmjobbehavior.py (+41/-0)
lib/lp/testing/factory.py (+15/-0)
lib/lp/testing/fakemethod.py (+51/-0)
lib/lp/testing/tests/test_fakemethod.py (+85/-0)
lib/lp/translations/model/translationtemplatesbuildbehavior.py (+50/-1)
lib/lp/translations/tests/test_translationtemplatesbuildbehavior.py (+157/-0)
lib/lp/translations/tests/test_translationtemplatesbuildjob.py (+0/-34)
Rejected for merging into lp:launchpad/db-devel
Eleanor Berger: Pending (code) requested
Diff: 575 lines (+418/-39) (has conflicts)
8 files modified
lib/lp/buildmaster/model/buildfarmjobbehavior.py (+15/-4)
lib/lp/buildmaster/tests/test_buildfarmjobbehavior.py (+41/-0)
lib/lp/testing/factory.py (+19/-0)
lib/lp/testing/fakemethod.py (+51/-0)
lib/lp/testing/tests/test_fakemethod.py (+85/-0)
lib/lp/translations/model/translationtemplatesbuildbehavior.py (+50/-1)
lib/lp/translations/tests/test_translationtemplatesbuildbehavior.py (+157/-0)
lib/lp/translations/tests/test_translationtemplatesbuildjob.py (+0/-34)
Revision history for this message
Muharem Hrnjadovic (al-maisan) wrote :

Related to https://bugs.launchpad.net/soyuz/+bugs?field.tag=buildfarm

Changed in rosetta:
status: New → In Progress
assignee: nobody → Muharem Hrnjadovic (al-maisan)
milestone: none → 10.01
Jeroen T. Vermeulen (jtv)
tags: added: wellington
Jeroen T. Vermeulen (jtv)
Changed in rosetta:
assignee: Muharem Hrnjadovic (al-maisan) → nobody
milestone: 10.01 → none
Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

To support this, TranslationTemplatesBuildJob must have a "build" attribute that refers to an IBuildBase implementation. It must provide its own updateBuild_WAITING and, as wgrant puts it, "an enormous web of stuff under there."

Soyuz build jobs have this reference pointing to a Build, but ours don't. Another class that doesn't have a Build there is SourcePackageRecipeBuild.

Revision history for this message
William Grant (wgrant) wrote :

You don't actually need to have an IBuildBase -- you could reimplement IBuildFarmJob.updateBuild to not require one. That was sort of the intention.

But it might be better for you to have a build anyway. You'll have to work out whether you want one.

Jeroen T. Vermeulen (jtv)
Changed in rosetta:
status: In Progress → Fix Committed
tags: added: qa-needstesting
Данило Шеган (danilo)
tags: added: qa-untestable
removed: qa-needstesting
Данило Шеган (danilo)
Changed in rosetta:
milestone: none → 10.02
assignee: nobody → Jeroen T. Vermeulen (jtv)
Данило Шеган (danilo)
Changed in rosetta:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.