AttributeError on potemplate page

Actually that oops is on a +translate page. We're clearly doing an EditByOwnersOrAdmins check on a POTemplateSubset, and a POTemplateSubset has no owner. I don't know why the check isn't looking at POFile instead.

Being a translations admin must bypass the broken check.

Well, the fact that EditPOTemplateSubset call EditByOwnersOrAdmins.checkAuthenticated at all shows that it's broken. I think for a fairly quick fix, id simply change that to check for admins only. We'd have to dig deeper to find out what was meant to happen here.

Adi,
I just saw that you introduced this checker. Let's talk about it next week to see what is really going wrong here.

I just confirmed that this only happens on edge. On production I get a "Lost something" page. Lowering the priority to High.

That was my unprivileged alter ego speaking ... ;-) I noticed when I tried to change the importance.

The check was added as an attempt to fix bug 340662 .

I don't understand exactly why was it necessary to introduce a new privilege for this? What was exactly wrong with the existing one? Bug 340662 was supposed to be only about introducing a more wider set of fields, and not changing *who* can get to them. For the fix, I'd mostly back out the change from 340662 except for adding new fields.

I tried to explain the changes here: https://bugs.edge.launchpad.net/rosetta/+bug/340662/comments/5

My rationale for changing the current permission system was that if we allow a person to disable a template, we should also allow to enable it back. We also had this bug for Ubuntu translation coordinators and with the current code this is not possible.

Maybe we can change the code so that both enabled and disable template will use IPOTemplate.