Launchpad itself

OOPS accessing translations page for a source package

Bug #488765 reported by Diogo Matsubara
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Henning Eggers
Launchpad itself 10.01

Bug Description

As seen in OOPS-1420EC974 an AssertionError: Name "+translations-upload" is not registered as a view or navigation step for "SourcePackage". was raised while navigating from +topcontributors to +translations page

Related branches

lp:~henninge/launchpad/bug-488765-oops-translations
Guilherme Salgado (community): Approve (code)
Canonical Launchpad Engineering: Pending (code) requested
Diff: 236 lines (+88/-51)
4 files modified
lib/lp/translations/browser/product.py (+22/-25)
lib/lp/translations/browser/tests/test_product_view.py (+2/-1)
lib/lp/translations/stories/standalone/xx-product-translations.txt (+54/-15)
lib/lp/translations/templates/product-translations.pt (+10/-10)
Данило Шеган (danilo)
Changed in rosetta:
status: New → Triaged
importance: Undecided → High
Revision history for this message
Данило Шеган (danilo) wrote :

This seems to try to load product-translations page on a sourcepackage (probably due to linking). We should probably not try that until the two objects are fully compatible.

Данило Шеган (danilo)
Changed in rosetta:
assignee: nobody → Henning Eggers (henninge)
Henning Eggers (henninge)
Changed in rosetta:
status: Triaged → In Progress
milestone: none → 10.01
Revision history for this message
Henning Eggers (henninge) wrote :

So, the culprit is primary_translatable which is a property of both IProduct and lp.translations.browser.ProductView. The view property returns a dictionary and filters for productseries. But the template (product-translations.pt) uses the model property (as "target") which may return source packges if no translatable series of the product exists. That's when "target/fmt:url/+translations-upload" fails because source packages don't have such a view.

So possible fixes are:
- make the template use the view property that only returns productseries,
- make the model property only return productseries,
- add a +translations-upload view for Sourcepacakage.

The latter might be a bit too much work to get rid of an oops.

Revision history for this message
Ursula Junque (ursinha) wrote : A commit mentioned this bug

This bug was mentioned in stable r10187 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/10187>

Changed in rosetta:
status: In Progress → Fix Committed
tags: added: qa-needstesting
Данило Шеган (danilo)
tags: added: qa-ok
removed: qa-needstesting
Curtis Hovey (sinzui)
Changed in rosetta:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.