Launchpad itself

Allow Rosetta admins to create custom language codes

Bug #487137 reported by Jeroen T. Vermeulen on 2009-11-23

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Launchpad itself	Fix Released	High	Henning Eggers	Launchpad itself 11.01

Bug Description

Now that we have the custom language codes UI (bug 271747), we should allow Translations experts to create and remove custom language codes.

This was always planned, but didn't fit in the original branch.

Tags:

Related branches

lp:~adiroiban/launchpad/bug-487137

Rejected for merging into lp:launchpad

Michael Nelson (community): Approve (code) on 2010-04-22

lp:~henninge/launchpad/devel-487137-custom-language-codes

Merged into lp:launchpad at revision 12142

Curtis Hovey (community): Approve (ui) on 2010-12-22

Jelmer Vernooij (community): Approve (code) on 2010-12-22

Данило Шеган (danilo) on 2009-11-30

Changed in rosetta:
importance:	Undecided → High
status:	New → Triaged

Adi Roiban (adiroiban) on 2010-04-22

Changed in rosetta:
assignee:	nobody → Adi Roiban (adiroiban)

Adi Roiban (adiroiban) on 2010-04-22

Changed in rosetta:
status:	Triaged → In Progress

Revision history for this message

Adi Roiban (adiroiban) wrote on 2010-05-20:

For IProduct we have the following admin permissions:
* registry admin - LP Admins and project owner
* translations admin - LP Admins, project owner and Rosetta Admins
* custom language code admin - LP Admins and Rosetta Admins

'Registry admin' is mapped to launchpad.Admin, while 'translations admin' is mapped to 'launchpad.TranslationsAdmin'

To solve this problem we have the following options

1. Allow project owners to administer custom language code. Danilo said that this is not an option right now.
2. Add a new launchpad.CustomLanguageCodeAdmin. From previous discussion on the LP-dev ML this is not the recommended solution.
3. Create new ProductWithCustomLanguageCode, DistributionWithCustomLanguageCode and SourcePackageWithCustomLanguage code object that will delegate IProduct, IDistribution... etc . From my point of view, this solution will only complicate the design of the code.

Are there any other options?

If we are going to solve this bug, what option should we choose?

Changed in rosetta:
assignee:	Adi Roiban (adiroiban) → nobody

Curtis Hovey (sinzui) on 2010-06-02

Changed in rosetta:
status:	In Progress → Triaged

Revision history for this message

Robert Collins (lifeless) wrote on 2010-11-19:

This has a branch which seems stalled, possibly a low hanging fruit to finish it off.

Henning Eggers (henninge) on 2010-12-21

Changed in launchpad:
assignee:	nobody → Henning Eggers (henninge)
status:	Triaged → In Progress
tags:	added: bugjam2010

Revision history for this message

Henning Eggers (henninge) wrote on 2010-12-22:

After discussion with Danilo I fixed this now by allowing project owners and rosetta admins to mange custom language codes. With the reorganization of the Launchpad team it is a Good Idea to take responsibilities like this away from the devs and let the users manage their projects by themselves. Watch for similar changes on the import queue ... ;)

Revision history for this message

Launchpad QA Bot (lpqabot) wrote on 2010-12-23: Bug fixed by a commit

Fixed in stable r12142 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/12142>.

tags:	added: qa-needstesting
Changed in launchpad:
status:	In Progress → Fix Committed

Revision history for this message

Данило Шеган (danilo) wrote on 2010-12-24:

I've tested adding and removing custom language codes as a Rosetta admin, as an otherwise unprivileged project owner and as an unprivileged user, and it all worked fine. The only minor issue I've seen is that even if I am unprivileged I can access +custom-language-codes page, but there's no link to it, but that's totally not important at the moment.

tags:

added: qa-ok
removed: qa-needstesting

Revision history for this message

Henning Eggers (henninge) wrote on 2010-12-24:

Thanks. That behavior was already known and even documented in the doctest. The doctest said it might be useful for debugging purposes.

Henning Eggers (henninge) on 2011-01-04

Changed in launchpad:
milestone:	none → 11.01

Curtis Hovey (sinzui) on 2011-01-11

Changed in launchpad:
status:	Fix Committed → Fix Released

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.