Launchpad itself

Don't ask me to import obsolete templates

Bug #462013 reported by Michael Terry
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Low
Adi Roiban
Launchpad itself 10.02

Bug Description

On a project's main translation page, there is a little box ("Set up translations for other series") that suggests I import templates for any series in my project that isn't yet imported. But it shouldn't bother listing obsolete series.

Related branches

lp:~adiroiban/launchpad/bug-462013-series-status (Merged)
lp:~adiroiban/launchpad/bug-462013-try-2
Michael Nelson (community): Approve (code)
Diff: 210 lines (+128/-18)
3 files modified
lib/lp/translations/browser/product.py (+12/-5)
lib/lp/translations/browser/tests/test_product_view.py (+58/-12)
lib/lp/translations/stories/productseries/xx-productseries-translations.txt (+58/-1)
Данило Шеган (danilo)
Changed in rosetta:
status: New → Triaged
importance: Undecided → Low
tags: added: ui
Данило Шеган (danilo)
tags: added: trivial
Adi Roiban (adiroiban)
Changed in rosetta:
status: Triaged → In Progress
assignee: nobody → Adi Roiban (adiroiban)
Revision history for this message
Adi Roiban (adiroiban) wrote :

Ok. Sorry for refactoring the DistroSeriesStatus to SeriesStatus as part of this fix, but I think it is better to do it now.

Let me know if you think this refactoring needs to be done in another branch. I could not find a bug report for it... only Guilherme Salgado comment in the code.

With this fix product serie with status SeriesStatus.OBSOLETE are not included in the list of series that are not set up for translations.

Revision history for this message
Данило Шеган (danilo) wrote :

I've commented on the MP: you definitely want separate branches for these, because that will make them much easier for review. Btw, thanks for both the refactoring and the fix.

Revision history for this message
Adi Roiban (adiroiban) wrote :

Sure. No problem. Just submitted the refactoring branch.

I will resubmit this fix after that branch is in devel.

Since Salgado's comment does not mention any bug report / bug nr, I was thinking he left that comment to be fixed together with ther first branch that come upon it.

Revision history for this message
Ursula Junque (ursinha) wrote : A commit mentioned this bug

This bug was mentioned in stable r10256 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/10256>

Changed in rosetta:
status: In Progress → Fix Committed
tags: added: qa-needstesting
Adi Roiban (adiroiban)
tags: added: qa-ok
removed: qa-needstesting
Данило Шеган (danilo)
Changed in rosetta:
milestone: none → 10.02
Данило Шеган (danilo)
Changed in rosetta:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.