Comment 14 for bug 201749

Revision history for this message
Adi Roiban (adiroiban) wrote :

I still think that ticking „needs review” on a translation that is current, should mark that message as not having any current translations.

Here is an usecase.

Step 1:

Original message: „1 + 1 = 2 ”
UserA (not a reviewer) suggestions: „1 + 1 = 2”
UserB (not a reviewer) suggestions: „1 + 1 = ?”

Step 2:
UserC is a reviewer and he want to add the following suggestion „1 + 1 = 3” but he forget to tick the „needs review”.
The „1 + 1 = 3” suggestion is makerd as current and all previous suggestions discarded.

Step3:
UserC realizes he/she forgot to tick the needs review so he/she ticks it now, while „1 + 1 = 3” is the current translation.

Actual result:
„1 + 1 = 3” will be listed as „needs review” , but the original suggestions are not.
If we don't have the „isrevied” db field, „1 + 1 = 3” will be displayed as being created now.

Expected result:
„1 + 1 = 2”, „1 + 1 = ?” and „1 + 1 = 3” should be all listed as suggestions with their correct creating date.
-----------

Please let me know if you consider this is a valid use case for ticking needs review on a current translation.