application indicator (needed for maverick integration)

Bug #588086 reported by Jon Lund Steffensen
22
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Redshift
Fix Released
Wishlist
Francesco Marella

Bug Description

Are there any plans to develop a redshift application-indicator as per the indicator-applet in Lucid? It would seem that the notification area, and thus gtk-redshift, will likely be deprecated by the time Maverick is released.

https://wiki.ubuntu.com/DesktopExperienceTeam/ApplicationIndicators

Related branches

Changed in redshift:
importance: Undecided → Wishlist
Revision history for this message
Jorge Castro (jorge) wrote :

Hi Jon, if you need any help porting this to application indicators please let me know!

Changed in redshift:
status: New → Confirmed
tags: added: indicator-application
Changed in redshift:
status: Confirmed → In Progress
Revision history for this message
Francesco Marella (francesco-marella) wrote :

Jon are you working on this bug? I see status set to 'in progress' but unassigned.
I've done some work on that and I could share if needed.

Revision history for this message
Jon Lund Steffensen (jonls) wrote :

Michael Speth has sent me his first draft on this; that's why I marked it as in progress. I have asked him to share his work here so we can collaborate. Francesco, please post any work you have done on this.

Revision history for this message
Francesco Marella (francesco-marella) wrote :

Added a link to the branch.

The configure script does not check if the appindicator python module is available. Comments are welcome, thanks.

Revision history for this message
Jon Lund Steffensen (jonls) wrote :

Looks great. Had I implemented it I would probably have made it check for appindicator in the python script at runtime and have the script fall back to statusicon if it isn't found. I think your solution, where either statusicon or appindicator is built in, is superior because only one of them is really needed. What I would like is a configure parameter, let's call it --enable-gui, that would take one of three argument: "no", "statusicon" or "appindicator". Hope you get the idea. I can do this when I merge your branch, though, if you don't want to mess too much with the autoconf script.

Changed in redshift:
assignee: nobody → Francesco Marella (francesco-marella)
milestone: none → 1.4
Revision history for this message
Michael Speth (conzar) wrote :

Yep, I converted the script to be more class centric and the syntax to be more python like. I'll take any suggestions on improving this. Also, if you like whats in the script, how should this be merged into Redshift? Should there be a new directory similar to gtk-redshift?

Revision history for this message
Michael Speth (conzar) wrote :

I forgot to include the new svg for when redshift is in the "off state" that the script requires

Revision history for this message
Francesco Marella (francesco-marella) wrote : Re: [Bug 588086] Re: application indicator (needed for maverick integration)

Il giorno ven, 04/06/2010 alle 19.47 +0000, Jon Lund Steffensen ha
scritto:
> Looks great. Had I implemented it I would probably have made it check
> for appindicator in the python script at runtime and have the script
> fall back to statusicon if it isn't found. I think your solution, where
> either statusicon or appindicator is built in, is superior because only
> one of them is really needed. What I would like is a configure
> parameter, let's call it --enable-gui, that would take one of three
> argument: "no", "statusicon" or "appindicator". Hope you get the idea. I
> can do this when I merge your branch, though, if you don't want to mess
> too much with the autoconf script.
Got the idea, and I agree. Please do it yourself, I'm not very handy
with autoconf.

I'm going to push a couple of commits and propose for merging my branch
so you can do a final review and merge.

cheers,
Francesco

Revision history for this message
Jon Lund Steffensen (jonls) wrote :

@Michael: In the meantime Francesco Marella has provided a clean and working solution. Please have a look at it.

Changed in redshift:
status: In Progress → Fix Committed
Changed in redshift:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Related questions

Remote bug watches

Bug watches keep track of this bug in other bug trackers.