pyHalebarde

Use proper exceptions

Bug #337662 reported by Olivier Le Thanh Duong
2
Affects Status Importance Assigned to Milestone
pyHalebarde
Fix Released
Low
Laurent Peuch
pyHalebarde clutter "Blanche de Watou"

Bug Description

The way we use exception isn't right. The explaination message of the exception should be in the definition of the exception itself, not given when we raise it

Related branches

lp:~pyhalebarde/pyhalebarde/exceptions (Merged)
Laurent Peuch (psycojoker)
Changed in pyhalebarde:
assignee: nobody → psycojoker
importance: Undecided → Low
status: New → Confirmed
Revision history for this message
Laurent Peuch (psycojoker) wrote :

Planned to be in 0.2.1

Revision history for this message
Laurent Peuch (psycojoker) wrote :

I'd like your reviews Olivier.

Changed in pyhalebarde:
status: Confirmed → In Progress
Laurent Peuch (psycojoker)
Changed in pyhalebarde:
status: In Progress → Fix Committed
Revision history for this message
Olivier Le Thanh Duong (olethanh) wrote :

reopening. the new exceptions don't work.
You should import the globals module where they are.
And whey you raise use globals.exceptionname

Changed in pyhalebarde:
status: Fix Committed → Confirmed
Revision history for this message
Laurent Peuch (psycojoker) wrote : Re: [Bug 337662] Re: Use proper exceptions

It was working, what did you broke ?

2009/5/7 Olivier Le Thanh Duong <email address hidden>

> reopening. the new exceptions don't work.
> You should import the globals module where they are.
> And whey you raise use globals.exceptionname
>
> ** Changed in: pyhalebarde
> Status: Fix Committed => Confirmed
>
> --
> Use proper exceptions
> https://bugs.launchpad.net/bugs/337662
> You received this bug notification because you are a member of
> pyhalebarde dev team, which is subscribed to pyHalebarde.
>
> Status in pyHalebarde: an adaptation of "Halebarde et Gonfanon" with
> pygame: Confirmed
>
> Bug description:
> The way we use exception isn't right. The explaination message of the
> exception should be in the definition of the exception itself, not given
> when we raise it
>

Revision history for this message
Olivier Le Thanh Duong (olethanh) wrote :

It seems fixed now

Changed in pyhalebarde:
milestone: none → clutter
status: Confirmed → Fix Committed
Laurent Peuch (psycojoker)
Changed in pyhalebarde:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.