PQM

string interpolation fail

Bug #297381 reported by Robert Collins
2
Affects Status Importance Assigned to Milestone
PQM
Triaged
Medium
Unassigned

Bug Description

in script.py:

        self.do_merge(from_repo_revision=self.from_branch,
                      to_repo_revision=self.to_branch,
                      merge_name='star-merge',
                      merge_method="do_star_merge",
                      line='merge %s %s' % (self.from_branch, self.to_branch))

The value of line here can contain % if the branch urls contain % (such as e.g. %7e) - this line is used in string formatting as the string to format later; either we should escape the urls appropriately, or we should (and this is probably better) pass the args to format further down, deferring any interpretation till the point of emission.

Revision history for this message
Robert Collins (lifeless) wrote :

This will show up as a 'silent failure' with a TypeError in the log. The workaround is to use url's without % in them (e.g. ~user).

Changed in pqm:
importance: Undecided → Medium
status: New → Triaged
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.