gen_action_registry.sh incorrectly generates Action Registry

Thanks for the report. Unfortunately, your fix does not work well with GNU sed. Does the original code work if you use "sed -E" instead?

Can you try these two lines?

class="$(echo $f | sed --posix "s/^actions\/\(\w\{0,\}\)\.hh/\1/g")"
id="$(echo $foo | sed --posix "s/PEEKABOT_REGISTER_SERIALIZABLE[[:space:]]\{1,\}//g")"

Hi Staffan,

> class="$(echo $f | sed --posix "s/^actions\/\(\w\{0,\}\)\.hh/\1/g")"
> id="$(echo $foo | sed --posix "s/
> PEEKABOT_REGISTER_SERIALIZABLE[[:space:]]\{1,\}//g")"

This does not work, --posix is not a valid flag. I also tried the
other suggested method:

> Does the original code work if you use "sed -E" instead?

which returns undesired values.

How about the following:

 class="$(echo $f | sed "s:actions\/*::" | sed "s:\([a-zA-Z]\)\.hh:
\1:g")"
 id="$(echo $foo | sed "s/[a-zA-Z_ ]*//g")"

I tried this on OS X and Debian linux and both worked.

Nate

Ah, sorry, what happens if you remove the "--posix" flag (which was put there by accident :)? I.e.

  class="$(echo $f | sed "s/^actions\/\(\w\{0,\}\)\.hh/\1/g")"
  id="$(echo $foo | sed "s/PEEKABOT_REGISTER_SERIALIZABLE[[:space:]]\{1,\}//g")"

Still a no-go?

What's the reason for using the ":" syntax, instead of the "/" syntax?

> class="$(echo $f | sed "s/^actions\/\(\w\{0,\}\)\.hh/\1/g")"
> id="$(echo $foo | sed "s/PEEKABOT_REGISTER_SERIALIZABLE[[:space:]]
> \{1,\}//g")"
>
> Still a no-go?

One line from the output follows:

Found action actions/SetJointMax.hh, id=95 (./actions/SetJointMax.hh)

So the id matching works, but not the definition of class.

> What's the reason for using the ":" syntax, instead of the "/" syntax?

Personal preference, I find it easier to read.

Nate

Or:

    class="$(echo $f | sed "s/^actions\/\([[:alnum:]]\{0,\}\)\.hh/\1/g")"
    id="$(echo $foo | sed "s/PEEKABOT_REGISTER_SERIALIZABLE[[:space:]]\{1,\}//g")"

As far as I can tell by reading the man pages for BSD sed and "re_format", this should be portable.

Ok. Thanks. I'll commit your variant of the class matching regexp then.

> class="$(echo $f | sed "s/^actions\/\([[:alnum:]]\{0,\}\)\.hh/\1/
> g")"
> id="$(echo $foo | sed "s/PEEKABOT_REGISTER_SERIALIZABLE[[:space:]]
> \{1,\}//g")"

This works.

Nate

Fix commited. Re-open the bug if it still doesn't work.