Identify and add missing symlinks for notify-osd-icons

Bug #453066 reported by David Barth
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
notify-osd-icons (Ubuntu)
Fix Released
Undecided
David Barth

Bug Description

Some applications are sending notification requests with icon names that are different from the one chosen for styling notify-osd notifications. Typically: Network Manager or gnome-power-manager.

We need to identify the list of notification icons to remap to our n-osd specific icons, then provide symlinks in notify-osd-icons to ensure the right icons are used.

Revision history for this message
David Barth (dbarth) wrote :

1. Take a look at the available n-osd icons to see which domains we were mapping
2. Cross that with the list of apps mentioned in the NotifyOSD spec
3. Extract the relevant package source to see which new icon names were used
4. Determine the mapping between original icon names and icon names mapped by n-osd

David Barth (dbarth)
Changed in notify-osd:
assignee: nobody → David Barth (dbarth)
importance: Undecided → High
status: New → In Progress
milestone: none → ubuntu-9.10
Revision history for this message
David Barth (dbarth) wrote :

system-config-printer, uses:
  printer

network-manager-applet, uses all these specific icons:
  nm-adhoc
  nm-device-wired
  nm-device-wwan
  nm-device-wireless
  nm-no-connection

rhythmbox, requires no notification icon (uses pixbufs of album arts)

evolution-indicator, n-osd patch already applied

banshee, requires no notification icon (uses pixbufs of album arts)

empathy, requires no notification icon (uses pixbufs for avatars)

pidgin-libnotify, requires no notification icon (uses pixbufs for avatars)

gnome-mount: not applicable once patched (notification turned into a dialog box)

gnome-settings-daemon, apart ftrom synchronous notifications added by our patch, requires:
 gsd-xrandr
 preferences-desktop-accessibility

gnome-power-manager:
gpm-ac-adapter.svg
gpm-battery-000-charging.svg
gpm-battery-000.svg
gpm-battery-020-charging.svg
gpm-battery-020.svg
gpm-battery-040-charging.svg
gpm-battery-040.svg
gpm-battery-060-charging.svg
gpm-battery-060.svg
gpm-battery-080-charging.svg
gpm-battery-080.svg
gpm-battery-100-charging.svg
gpm-battery-100.svg
gpm-battery-charged.svg
gpm-keyboard-000.svg
gpm-keyboard-020.svg
gpm-keyboard-040.svg
gpm-keyboard-060.svg
gpm-keyboard-080.svg
gpm-keyboard-100.svg
gpm-mouse-000.svg
gpm-mouse-020.svg
gpm-mouse-040.svg
gpm-mouse-060.svg
gpm-mouse-080.svg
gpm-mouse-100.svg
gpm-phone-000.svg
gpm-phone-020.svg
gpm-phone-040.svg
gpm-phone-060.svg
gpm-phone-080.svg
gpm-phone-100.svg
gpm-primary-000-charging.svg
gpm-primary-000.svg
gpm-primary-020-charging.svg
gpm-primary-020.svg
gpm-primary-040-charging.svg
gpm-primary-040.svg
gpm-primary-060-charging.svg
gpm-primary-060.svg
gpm-primary-080-charging.svg
gpm-primary-080.svg
gpm-primary-100-charging.svg
gpm-primary-100.svg
gpm-primary-charged.svg

Besides on gpm, there are many stock icons being used that could be replaced by better icons:
- error on suspend or hibernate being disabled by admin: GPM_STOCK_APP_ICON
- on "power information" key pressed, GTK_STOCK_DIALOG_INFO

The rest seems to be used by some dead code paths:
- on "low capacity" warning, GTK_STOCK_DIALOG_INFO
- on "fully charged" event, GTK_STOCK_DIALOG_INFO

Revision history for this message
David Barth (dbarth) wrote :

Missing symlinks mapping requests to icons in the current set. Attached patch for the notify-osd-icons branch

David Barth (dbarth)
Changed in notify-osd:
status: In Progress → Fix Committed
David Barth (dbarth)
Changed in notify-osd:
status: Fix Committed → Fix Released
Changed in notify-osd-icons (Ubuntu):
status: New → Fix Released
no longer affects: notify-osd
Changed in notify-osd-icons (Ubuntu):
assignee: nobody → David Barth (dbarth)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.