Moin OpenID module

OOPS when trying to login using openid from a page that contains spaces in the URL

Bug #338228 reported by Ursula Junque on 2009-03-05

Affects		Status	Importance	Assigned to	Milestone
	Moin OpenID module	Fix Committed	Medium	Rowan Kerr

Bug Description

Steps to reproduce:
1) Go to a wiki that uses openid, wiki.ubuntu.com, for instance
2) Being logged out, try to access a page that contains spaces in the URL, e.g. https://wiki.ubuntu.com/Artwork/Incoming/Jaunty/Kxx Wallpaper
3) It should show a message: "OpenID error: None.", won't login and will produce the OOPS:
OOPS-1159A285

MalformedReturnURL: None

Also: OOPS-1159C1049

See original description

Tags:

Related branches

lp:~rowan/moin-openid/bugfix

Ursula Junque (ursinha) on 2009-03-05

description:

updated

Revision history for this message

Francis J. Lacoste (flacoste) wrote on 2009-03-05:

This is a bug on the moin side. It's not encoding the return_url properly.

Revision history for this message

James Henstridge (jamesh) wrote on 2009-03-05:

So the Moin plugin will need fixing for login to work in this case.

The best Launchpad can do here is to report the error gracefully.

Revision history for this message

Francis J. Lacoste (flacoste) wrote on 2009-03-06:

It also doesn't encode URLs with accented characters in them: OOPS-1161C910

Changed in moin-openid:
importance:	Undecided → High
status:	New → Triaged
importance:	High → Medium

Joey Stanford (joey) on 2009-03-12

Changed in moin-openid:
assignee:	nobody → rowan

Revision history for this message

Rowan Kerr (rowan) wrote on 2009-03-18:

moin-urlencode-338228.diff Edit (555 bytes, text/plain)

The Moin path needed to be escaped when the continuation url was created. It wasn't being taken care of farther down the chain in either Moin or the Python OpenID libs.

Rowan Kerr (rowan) on 2009-03-18