Page <title> when reporting a bug is geeky and repetitive

Bug #429735 reported by Matthew Paul Thomas
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Unassigned

Bug Description

1. Go to <https://bugs.edge.launchpad.net/ubuntu/+source/indicator-session/+filebug>.
2. Look at the title bar.

What you see: "+filebug : Bugs in indicator-session : “indicator-session” package : Ubuntu"
What you should see: "Reporting a bug in “indicator-session” package in Ubuntu"

Revision history for this message
Deryck Hodge (deryck) wrote :

Yes, this is terrible. My assumption is that this is a result of the changes from barry's heading rules change branch.

Changed in malone:
status: New → Triaged
importance: Undecided → High
milestone: none → 3.0
Revision history for this message
Jonathan Lange (jml) wrote :

I presume then that the bug is not actually in malone?

Revision history for this message
Deryck Hodge (deryck) wrote :

After looking at the wiki rules closely for headings and titles, it seems we need to do a page_title on the view, which isn't yet being done, and specify a property on the view to override the reverse breadcrumbs. That makes this a bug in our malone view class, but it may be happening elsewhere. However, the wiki (https://dev.launchpad.net/VersionThreeDotO/UI/Conversion#Heading%20rules) says:

"Generally, you will not want to do this, so that the default reverse-breadcrumbs are used."

So I guess this title form should be the norm. I find it a little odd, though, at least on the filebug page. And I can't really imagine why we would want this for a page title anywhere. Having said that, I haven't noticed this anywhere but the +filebug page. So maybe the rules aren't exactly correct on the wiki. Maybe just having a page_title method on the view is enough.

Revision history for this message
Jonathan Lange (jml) wrote : Re: [Bug 429735] Re: Page <title> when reporting a bug is geeky and repetitive

On Wed, Sep 16, 2009 at 11:12 AM, Deryck Hodge
<email address hidden> wrote:
> After looking at the wiki rules closely for headings and titles, it
> seems we need to do a page_title on the view, which isn't yet being
> done, and specify a property on the view to override the reverse
> breadcrumbs.  That makes this a bug in our malone view class, but it may
> be happening elsewhere.  However,  the wiki
> (https://dev.launchpad.net/VersionThreeDotO/UI/Conversion#Heading%20rules)
> says:
>
> "Generally, you will not want to do this, so that the default reverse-
> breadcrumbs are used."
>
> So I guess this title form should be the norm.  I find it a little odd,
> though, at least on the filebug page.  And I can't really imagine why we
> would want this for a page title anywhere.  Having said that, I haven't
> noticed this anywhere but the +filebug page.  So maybe the rules aren't
> exactly correct on the wiki.  Maybe just having a page_title method on
> the view is enough.
>

I might have noticed other places, but I haven't been keeping a
record, nor filing bugs.

Perhaps it's worth asking on the mailing list whether this is the
expected behaviour?

jml

Revision history for this message
Barry Warsaw (barry) wrote :

Martin has said that the <title> should be the reversed breadcrumbs, and that's what you'll get if you do not specify view.override_title_breadcrumbs=True. IIUC, Salgado has/is about to land a branch where the final +foo component is taken from the view.page_title if available. Note that you must set both attributes to override the reverse-breadcrumb in <title>.

I've updated the wiki rules to be (hopefully) clearer on this. I think it's still TBD whether setting view.page_title on every view can be relaxed with a better default. But I still think that setting override_title_breadcrumbs should be very rare. The base-layout rules should by default set the <title> correctly.

Revision history for this message
Francis J. Lacoste (flacoste) wrote :

I think this is really an issue for Martin to settle.

Changed in malone:
assignee: nobody → Martin Albisetti (beuno)
Revision history for this message
Guilherme Salgado (salgado) wrote :

Once my fix for bug 423691 lands, the title of that page will be "Reporting a bug in “indicator-session” package in Ubuntu : Bugs in indicator-session : “indicator-session” package : Ubuntu", which is certainly better than what we currently have (the one starting with +filebug).

Revision history for this message
Deryck Hodge (deryck) wrote :

I chatted with Martin and Barry about this and will respond on the dev list with the end result of that conversation. For the purpose of this bug, we'll use override_title_breadcrumbs to get a better human-readable title.

So that work will fall to we bugs hackers. I'll un-assign Martin.

Changed in malone:
assignee: Martin Albisetti (beuno) → nobody
Deryck Hodge (deryck)
Changed in malone:
milestone: 3.0 → 3.1.10
tags: added: ui-debt
Revision history for this message
Deryck Hodge (deryck) wrote :

While I don't think we fixed this as fully as mpt would like, i.e. returning to a simple string, there was some work to make this better. So the really bad "geeky and repetitive" part of this is fixed now. Maybe slightly repetitive still, but getting there. :)

Closing this as fixed released, since any further work is in the hands of registry as they and beuno decide whether or not to refine the rules for headings and page titles.

Changed in malone:
milestone: 3.1.10 → none
status: Triaged → Fix Released
Revision history for this message
Matthew Paul Thomas (mpt) wrote :

It is indeed less geeky, but it's now even *more* repetitive than it was before: "Report a bug about “indicator-session” package in Ubuntu : Bugs : “indicator-session” package : Ubuntu". Criminy.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.