Launchpad itself

Project bugs page "Subscribe" link has inappropriate edit icon

Bug #419965 reported by Matthew Paul Thomas
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Low
Eleanor Berger
Launchpad itself 3.1.10

Bug Description

On a project Bugs page, such as <https://bugs.edge.launchpad.net/bzr>, the "Subscribe to bug mail" link has an edit icon. This is inappropriate: subscribing isn't editing.

It may save time to fix this at the same time as bug 193873.

Tags: lp-bugs

Related branches

lp:~intellectronica/launchpad/bugmail-ui-fixes
Gavin Panella (community): Approve (code)
Martin Albisetti (community): Approve (ui)
Michael Nelson (community): Approve (ui)
Canonical Launchpad Engineering: Pending (code ui) requested
Diff: 390 lines
10 files modified
lib/canonical/launchpad/browser/structuralsubscription.py (+30/-1)
lib/canonical/launchpad/database/structuralsubscription.py (+11/-0)
lib/canonical/launchpad/interfaces/structuralsubscription.py (+3/-0)
lib/lp/registry/browser/distribution.py (+2/-5)
lib/lp/registry/browser/distroseries.py (+5/-10)
lib/lp/registry/browser/milestone.py (+2/-6)
lib/lp/registry/browser/product.py (+3/-10)
lib/lp/registry/browser/productseries.py (+5/-12)
lib/lp/registry/configure.zcml (+14/-7)
lib/lp/registry/model/milestone.py (+4/-0)
Revision history for this message
Eleanor Berger (intellectronica) wrote :

Subscribing is, in fact, editing. You can edit your personal subscription or the subscription of any of the teams you're a member of. It may even be better to change the language, at least conditionally.

Revision history for this message
Deryck Hodge (deryck) wrote :

This can (and will) be cleaned up in the page redesign for 3.0.

Changed in malone:
importance: Undecided → Low
milestone: none → 3.0
status: New → Triaged
Revision history for this message
Deryck Hodge (deryck) wrote :

Tom, I didn't see your comment when I triaged. I agree with mpt here; subscribing is editing only from the DB point of view or in a metaphorical sense. To ask someone to subscribe is more a call to action, like the plus icon implies (though honestly there are metaphor/language breakdowns there, too).

The edit icon seems appropriate to me after someone is subscribed if the action carries the person to an edit menu or AJAXified overlay to adjust subscription settings. I've seen this on branch pages, I believe.

Deryck Hodge (deryck)
Changed in malone:
assignee: nobody → Tom Berger (intellectronica)
Deryck Hodge (deryck)
Changed in malone:
milestone: 3.0 → 3.1.10
Eleanor Berger (intellectronica)
Changed in malone:
status: Triaged → In Progress
Eleanor Berger (intellectronica)
Changed in malone:
status: In Progress → Fix Committed
Diogo Matsubara (matsubara)
Changed in malone:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.