Launchpad itself

Make it possible for registry admins to hide comments

Bug #220535 reported by Björn Tillenius
18
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Critical
j.c.sackett

Bug Description

The admins can hide bug comments using the API already. They should be able to do this through the UI as well, so that they don't have to run a script to do it.

See original description
Tags: lp-bugs qa-ok

Related branches

lp:~jcsackett/launchpad/spam-messages-visibility
Gavin Panella (community): Approve
Stuart Bishop (community): Approve (db)
Robert Collins: Pending (db) requested
Diff: 809 lines (+274/-201)
20 files modified
database/sampledata/current-dev.sql (+101/-84)
database/sampledata/current.sql (+101/-84)
database/schema/comments.sql (+1/-1)
database/schema/patch-2208-51-0.sql (+18/-0)
lib/canonical/launchpad/database/message.py (+2/-0)
lib/canonical/launchpad/interfaces/message.py (+2/-0)
lib/canonical/launchpad/pagetests/webservice/xx-hide-comments.txt (+2/-2)
lib/canonical/launchpad/security.py (+10/-0)
lib/canonical/launchpad/zcml/message.zcml (+4/-3)
lib/lp/bugs/browser/bugcomment.py (+1/-1)
lib/lp/bugs/configure.zcml (+1/-1)
lib/lp/bugs/doc/bugmessage-visibility.txt (+9/-8)
lib/lp/bugs/interfaces/bug.py (+1/-1)
lib/lp/bugs/interfaces/bugmessage.py (+0/-2)
lib/lp/bugs/model/bug.py (+1/-1)
lib/lp/bugs/model/bugmessage.py (+0/-1)
lib/lp/bugs/security.py (+2/-7)
lib/lp/bugs/stories/bugs/xx-bug-hidden-comments.txt (+1/-1)
lib/lp/bugs/tests/test_bug_messages_webservice.py (+1/-1)
lib/lp/scripts/utilities/sanitizedb.py (+16/-3)
lp:~jcsackett/launchpad/spam-button-ui
Gavin Panella (community): Approve
Diff: 498 lines (+337/-24)
8 files modified
lib/lp/answers/browser/question.py (+4/-0)
lib/lp/answers/browser/tests/test_questionmessages.py (+49/-20)
lib/lp/answers/javascript/question_spam.js (+73/-0)
lib/lp/answers/javascript/tests/test_question_spam.html (+80/-0)
lib/lp/answers/javascript/tests/test_question_spam.js (+93/-0)
lib/lp/answers/templates/question-index.pt (+11/-3)
lib/lp/answers/templates/questionmessage-display.pt (+17/-1)
lib/lp/testing/factory.py (+10/-0)
lp:~jcsackett/launchpad/spam-button-ui-bugs
Curtis Hovey (community): Approve (code)
Diff: 703 lines (+414/-93)
11 files modified
lib/lp/answers/javascript/question_spam.js (+3/-3)
lib/lp/bugs/browser/bugcomment.py (+28/-8)
lib/lp/bugs/browser/bugtask.py (+10/-5)
lib/lp/bugs/browser/tests/test_bugcomment.py (+97/-2)
lib/lp/bugs/browser/tests/test_bugcomment_visibility.py (+0/-73)
lib/lp/bugs/javascript/bug_spam.js (+72/-0)
lib/lp/bugs/javascript/tests/test_bug_spam.html (+94/-0)
lib/lp/bugs/javascript/tests/test_bug_spam.js (+93/-0)
lib/lp/bugs/stories/bugs/xx-bug-activity.txt (+1/-0)
lib/lp/bugs/templates/bugcomment-box.pt (+10/-0)
lib/lp/bugs/templates/bugtask-index.pt (+6/-2)
Revision history for this message
Matthew Paul Thomas (mpt) wrote :

See also bug 45419.

Revision history for this message
Diogo Matsubara (matsubara) wrote :

When a comment with an attachment is removed, we see OOPS like OOPS-842A2549 (AssertionError: 2044529)

Changed in malone:
status: New → Confirmed
Björn Tillenius (bjornt)
description: updated
Revision history for this message
Björn Tillenius (bjornt) wrote :

OOPSes like OOPS-842A2549 won't happen if we hide the comments, rather than delete them.

Revision history for this message
Tom Haddon (mthaddon) wrote :

I think having admins run manual SQL queries is enough of a bad thing that this should be marked of high importance.

Changed in malone:
importance: Undecided → High
Revision history for this message
Graham Binns (gmb) wrote :

Targeting this to 2.2.4. The DB patch has already landed and it would make the LOSAs happy.

Changed in malone:
milestone: none → 2.2.4
status: Confirmed → Triaged
Revision history for this message
Curtis Hovey (sinzui) wrote :

I think I disagree with what is about to be done. Message.visible of the correct is the right place to disable messages. CodeReviewComment and QuestionComment will require separate implementations where only one is desired.

We need a single view for all classes that have an IMessage, and make it accessible to anyone performing CHR. The view exposes the visible property and text_contents (for redaction). The CHR person can navigate to the message where he an see a link to administer the message.

/me had just started a branch to do this when he saw the activity on this bug.

Graham Binns (gmb)
Changed in malone:
assignee: nobody → Deryck Hodge (deryck)
Revision history for this message
Björn Tillenius (bjornt) wrote : Bug fixed by a commit

Fixed in devel r8225.

Changed in malone:
status: Triaged → Fix Committed
Revision history for this message
Björn Tillenius (bjornt) wrote : Re: Make it possible for admins to hide bug comments

This bug wasn't completely fixed by the branch that landed in r8225.

Changed in malone:
status: Fix Committed → In Progress
Revision history for this message
Diogo Matsubara (matsubara) wrote : Bug fixed by a commit

Fixed in devel r8225.

Changed in malone:
status: In Progress → Fix Committed
Revision history for this message
Deryck Hodge (deryck) wrote : Re: Make it possible for admins to hide bug comments

This wasn't completely fixed in r8225. My mistake in the commit message.

Changed in malone:
status: Fix Committed → In Progress
Björn Tillenius (bjornt)
summary: - Make it possible for admins to hide bug comments
+ Add UI for admins to hide bug comments
description: updated
summary: - Add UI for admins to hide bug comments
+ Make it possible for admins to hide bug comments
Changed in malone:
assignee: Deryck Hodge (deryck) → nobody
importance: High → Medium
milestone: 2.2.4 → none
status: In Progress → Triaged
Revision history for this message
sebastian-s (sebastian-s) wrote :

will this hide the comments for the normal user as well?

Revision history for this message
Deryck Hodge (deryck) wrote :

Yes, if a Launchpad admin hides a comment, it will be hidden to all users.

Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

r10287 in db-stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/db-stable/revision/10287) is part of this bug's fix.

Changed in launchpad:
assignee: nobody → j.c.sackett (jcsackett)
milestone: none → 11.04
status: Triaged → In Progress
Revision history for this message
j.c.sackett (jcsackett) wrote :

I'm removing myself from this as it may be a while before I can work on/land the next set of code.

Changed in launchpad:
status: In Progress → Triaged
assignee: j.c.sackett (jcsackett) → nobody
Revision history for this message
Robert Collins (lifeless) wrote :

The related branch is only a refactoring, bug 1 still loads on qastaging if we're persistent enough.

tags: added: qa-untestable
tags: added: qa-ok
removed: qa-untestable
Curtis Hovey (sinzui)
Changed in launchpad:
milestone: 11.04 → 11.05
summary: - Make it possible for admins to hide bug comments
+ Make it possible for registry admins to hide bug comments
Changed in launchpad:
assignee: nobody → j.c.sackett (jcsackett)
importance: Medium → Critical
summary: - Make it possible for registry admins to hide bug comments
+ Make it possible for registry admins to hide comments
Curtis Hovey (sinzui)
Changed in launchpad:
milestone: 11.05 → 11.06
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r13004 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/13004>.

Changed in launchpad:
milestone: 11.06 → 11.05
tags: added: qa-needstesting
removed: qa-ok
Changed in launchpad:
status: Triaged → Fix Committed
William Grant (wgrant)
tags: added: qa-ok
removed: qa-needstesting
j.c.sackett (jcsackett)
Changed in launchpad:
status: Fix Committed → In Progress
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r13026 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/13026>.

Changed in launchpad:
milestone: 11.05 → none
tags: added: qa-needstesting
removed: qa-ok
Changed in launchpad:
status: In Progress → Fix Committed
j.c.sackett (jcsackett)
tags: added: qa-ok
removed: qa-needstesting
William Grant (wgrant)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.