Comment 6 for bug 172501

Revision history for this message
Matt Zimmerman (mdz) wrote : Re: [Bug 172501] Re: reject non-code patch attachements

On Wed, Feb 06, 2008 at 10:44:18AM -0000, Emmet Hikory wrote:
> Documentation to elaborate "What is a patch" would be good, but it ought
> include not only unified diffs to code, but also other useful formats.
> Examples might include modified graphic files (e.g. background
> transparency for icons), recreated sounds (when sounds are non-free, or
> otherwise not correct), etc. While it is the common case, the preferred
> form for modification is not always text, and the preferred form for
> reception of alterations is not always diff (xdiff of .png (or even diff
> of .sng) is painful).

I think we need to reconsider the use cases we are trying to address.

The only one I know of is enabling developers to search for bugs which have
a patch (which I would define generally as a ready-to-merge fix) available,
so that they can review and merge them. For this use case, recording which
attachment is relevant is not necessary, and a simple "patch" tag (as used
in debbugs) would suffice, and avoid all of this confusion about identifying
attachments.

--
 - mdz