history.py uses deprecated (and deleted) ProgressBarStack

Bug #382765 reported by Matt Nordhoff
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
loggerhead
Fix Released
Critical
Michael Hudson-Doyle

Bug Description

history.py:

class ThreadSafeUIFactory (bzrlib.ui.SilentUIFactory):

    def nested_progress_bar(self):
        if getattr(uihack, '_progress_bar_stack', None) is None:
            pbs = bzrlib.progress.ProgressBarStack(
                      klass=bzrlib.progress.DummyProgress)
            uihack._progress_bar_stack = pbs
        return uihack._progress_bar_stack.get_nested()

This causes a DeprecationWarning:

.../loggerhead/history.py:63: DeprecationWarning: bzrlib.progress.ProgressBarStack was deprecated in version 1.12.
  klass=bzrlib.progress.DummyProgress)

lp:~beuno/loggerhead/deprecate should be updated to fix this.

Revision history for this message
Matt Nordhoff (mnordhoff) wrote :

There's now a branch up for review for bzr that deletes ProgressBarStack -- lp:~mbp/bzr/deprecation

Changed in loggerhead:
importance: Medium → High
milestone: none → 1.16rc1
Revision history for this message
Matt Nordhoff (mnordhoff) wrote :

This has now landed in bzr.dev r4418.

summary: - history.py uses deprecated ProgressBarStack
+ history.py uses deprecated (and deleted) ProgressBarStack
Changed in loggerhead:
importance: High → Critical
Revision history for this message
Matt Nordhoff (mnordhoff) wrote :

That branch has now landed in bzr.dev r4418.

Martin Albisetti (beuno)
Changed in loggerhead:
assignee: nobody → Michael Hudson (mwhudson)
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

I finally found a test case (bazaar.launchpad.net, sadly!) and fixed this.

Changed in loggerhead:
status: Triaged → Fix Committed
Martin Albisetti (beuno)
Changed in loggerhead:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.