loggerhead should generate links based on revision numbers

Bug #138021 reported by Michael Hudson-Doyle
10
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Undecided
Unassigned
loggerhead
Fix Released
Undecided
Martin Albisetti
1.6
Fix Released
Undecided
Unassigned

Bug Description

Well, I think so anyway.

This may be a bit contentious, as revno-based links may not be stable. I think it's a win overall though.

Tags: lp-code

Related branches

Revision history for this message
Robey Pointer (robey) wrote :

i believe if you use a revno in the url instead of a revid, it will "just work", so it's just a matter of changing how the urls are generated. i don't really care either way, but i have a vague memory of revnos being a contentious issue on the mailing list.

Revision history for this message
Tim Penhey (thumper) wrote :

It definitely makes for cleaner URLs.

Launchpad already just uses revnos to point to loggerhead.

Revision history for this message
Tim Penhey (thumper) wrote :

Not really a launchpad-bazaar problem, so marking that bit as invalid.

Changed in launchpad-bazaar:
status: New → Invalid
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

The launchpad-bazaar part of this is merging and deploying a version of loggerhead with the appropriate changes in. I'd like to keep that please.

Changed in launchpad-bazaar:
status: Invalid → Confirmed
Martin Albisetti (beuno)
Changed in loggerhead:
status: New → Confirmed
Martin Albisetti (beuno)
Changed in loggerhead:
assignee: nobody → beuno
status: Confirmed → In Progress
Martin Albisetti (beuno)
Changed in loggerhead:
status: In Progress → Fix Committed
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

I split off bug 246119 for the file id/file path thing and marking this fix released for launchpad-bazaar as we're now running the revno-based link generation loggerhead code.

Changed in launchpad-bazaar:
status: Confirmed → Fix Released
Martin Albisetti (beuno)
Changed in loggerhead:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.