dc1394_deinterlace_stereo_frames return wrong value on success

Bug #360520 reported by basarugur
2
Affects Status Importance Assigned to Milestone
libdc1394
Fix Released
Low
Peter Antoniac

Bug Description

dc1394_deinterlace_stereo_frames(in, out, method) function contains a switch with two cases.

however DC1394_INVALID_STEREO_METHOD error is returned once the execution gets out of the switch:
        switch (method) {
        case DC1394_STEREO_METHOD_INTERLACED:
           ...
            break;
        case DC1394_STEREO_METHOD_FIELD:
           ...
          break;
        }
        return DC1394_INVALID_STEREO_METHOD;

 this error should be returned in the "default" section of the switch and DC1394_SUCCESS should be returned when execution gets out of the switch; like:
        switch (method) {
        case DC1394_STEREO_METHOD_INTERLACED:
           ...
            break;
        case DC1394_STEREO_METHOD_FIELD:
           ...
          break;
       default:
        return DC1394_INVALID_STEREO_METHOD;
        }
        return DC1394_SUCCESS;

Revision history for this message
Peter Antoniac (pan1nx) wrote :

Hi,

Thank you for your bug report. This bug has been reported to the developers of the software. I will keep you posted about the progress on this bug. For now, I will mark this bug as invalid (as it is not related to the packaging nor Ubuntu...).

Thanks again!

Changed in libdc1394:
assignee: nobody → Peter Antoniac (theseinfeld)
importance: Undecided → Low
milestone: none → 2.1.0
status: New → Invalid
milestone: 2.1.0 → 2.1.1
Revision history for this message
Peter Antoniac (pan1nx) wrote :

Fixed in Upstream (SVN: 594)

Changed in libdc1394:
status: Invalid → Fix Committed
Revision history for this message
Peter Antoniac (pan1nx) wrote :

Available in 2.1.2

Changed in libdc1394:
status: Fix Committed → Fix Released
Peter Antoniac (pan1nx)
Changed in libdc1394:
milestone: 2.1.1 → 2.1.4
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.