Launchpad itself

Title of add subscription widget can wrap if long.

Bug #771335 reported by Benji York
16
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Benji York

Bug Description

If the bug target name is long the title of the subscription add/edit form can wrap. Se attached screen shot for example.

Related branches

lp:~benji/launchpad/fix-generated-html
j.c.sackett (community): Approve
Diff: 164 lines (+97/-6)
3 files modified
lib/lp/bugs/templates/bugtarget-bugs.pt (+11/-1)
lib/lp/registry/javascript/structural-subscription.js (+31/-3)
lib/lp/registry/javascript/tests/test_structural_subscription.js (+55/-2)
Revision history for this message
Benji York (benji) wrote :
Benji York (benji)
tags: added: story-better-bug-notification
Revision history for this message
Gary Poster (gary) wrote :

We've asked Huw for some help on this issue.

Benji York (benji)
Changed in launchpad:
assignee: nobody → Benji York (benji)
status: Triaged → In Progress
Revision history for this message
Benji York (benji) wrote :

This is really easy to do by adding the text-overflow: ellipsis style to
the title of the overlay.

Unfortunately, the only major browser not to support text-overlay is
Firefox. Since we're depending on JS for this functionality anyway, we
can detect Firefox and clip the title string as needed and add ellipsis.

Here are screen shots of Chrome doing the sane thing with text-overflow
and of the JS ellipsifying in FF: http://imgur.com/a/ryCF3.

Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r13035 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/13035>.

tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
Revision history for this message
William Grant (wgrant) wrote :

Works fine on sensible engines, but the Gecko hack CSS is only present on BugTarget:+bugs-index, not BugTarget:+bugs or +subscriptions.

tags: added: qa-ok
removed: qa-needstesting
William Grant (wgrant)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.