Launchpad itself

code review "Resubmit" has no option to give a comment or carry across previous comment

Bug #383352 reported by John A Meinel
18
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Medium
Unassigned

Bug Description

When it comes time to "Resubmit" a branch for review (because you made updates, or whatever) you set the status to Resubmit, and it creates a new merge request which supersedes the previous one.

However, it doesn't give you the option to set a message at that point. So you have to Resubmit, then enter a new comment, which generates 2 emails.

It seems pretty straightforward that at the time you want to Resubmit you want to add an (optional) comment, just like when you submit a merge request the first time.

Also, it would be nice if the comment could be automatically filled in with a "reply" version of the last comment. I'm not entirely sure how that would work, but there have been times where I resubmitted and just wanted to tweak some of what I said the first time.

John A Meinel (jameinel)
affects: launchpad → launchpad-code
Revision history for this message
mouahed2010 (mouahed-elnahali) wrote : Re: [Bug 383352] Re: code review "Resubmit" has no option to give a comment or carry across previous comment

Soory you are at the wrong email and person Idon't why I'm not a
professionnel in fixing and reapirind Bugs in Ubuntu I wish you find a
solution good luck.

Jonathan Lange (jml)
tags: added: ui
Revision history for this message
Jonathan Lange (jml) wrote :

To me, this seems like a detail of bug 382827.

Changed in launchpad-code:
importance: Undecided → Medium
status: New → Triaged
Revision history for this message
John A Meinel (jameinel) wrote :

Arguably it is. Though when I *do* want to resubmit one of my proposals that is an explicit action and it should have certain steps (like giving a commit message).

When I want to request someone else should do some work and eventually Resubmit on their own, that is a different set of actions.

(From what I've been able to determine "Needs Fixing" is supposed to == the later option, and this bug would then just be about cleaning up the steps to occur when deciding that you want to Resubmit your request.)

Revision history for this message
James Westby (james-w) wrote :

Hi,

Is this fixed with the recent(ish) changes to show comments from before
the resubmit?

Thanks,

James

Revision history for this message
Aaron Bentley (abentley) wrote :

I'm not sure if the use case is actually addressed. Now that we have descriptions instead of just initial comments, the description *is* carried across, but it's not optional. If John wants to change the description, he has to do it after resubmitting, which again generates an extra email.

Revision history for this message
John A Meinel (jameinel) wrote :

The original observation could probably be considered fixed.

The main problem i was having with resubmit was that post-resubmit there was *no* description/comment on the new proposal.

I would probably prefer resubmit to give you a text-area that was pre-populated with the previous description. But the core issue is handled.

Revision history for this message
Aaron Bentley (abentley) wrote :

Resubmit now does give you a textarea that is pre-populated with the previous description.

Changed in launchpad:
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.