firefox-3.{5,6} bug, merge review comments don't get wrapped in <pre> block

I can confirm this bug, using a new firefox 3.2 profile, and with my current 3.1 profile too.

So I guess its not so low priority like that.

$ apt-cache policy firefox-3.2
firefox-3.2:
  Installed: 3.2~a1~hg20090127r24317+nobinonly-0ubuntu1~fta1
  Candidate: 3.2~a1~hg20090127r24317+nobinonly-0ubuntu1~fta1
  Version table:
 *** 3.2~a1~hg20090127r24317+nobinonly-0ubuntu1~fta1 0
        500 http://ppa.launchpad.net jaunty/main Packages
        100 /var/lib/dpkg/status

$ apt-cache policy firefox-3.1
firefox-3.1:
  Installed: 3.1~b3~hg20090122r22900+nobinonly-0ubuntu1
  Candidate: 3.1~b3~hg20090122r22900+nobinonly-0ubuntu1
  Version table:
 *** 3.1~b3~hg20090122r22900+nobinonly-0ubuntu1 0
        500 ftp://darkstar.ist.utl.pt jaunty/universe Packages
        500 ftp://archive.ubuntu.com jaunty/universe Packages
        100 /var/lib/dpkg/status
     3.1~b3~hg20090122r22900+nobinonly-0ubuntu1~fta1 0
        500 http://ppa.launchpad.net jaunty/main Packages

FYI, also a problem on Firefox 3.2 on Windows XP. So not platform-specific.

firefox-3.1 has this issue too fwiw.

This isn't a Launchpad problem AFAIK. Looks correct with Firefox 3.0.6.

s/firefox-3.1/firefox-3.5/
s/firefox-3.2/firefox-3.6/

Dominic: We are unable to provide support for 3.6. Can you please provide the commands and output for the following commands

apt-cache policy firefox-3.0 firefox-3.5 firefox-3.6
lsb_release -a

The commands above should be typed the way i did, first the policy command than after that is finished run the lsb_ command.

John: no problem, I was just reporting that it effects both firefox-3.5 and firefox-3.6 (i.e., it is also broken in firefox trunk), I would only expect the bug to be tracked against 3.5 for Ubuntu

$ apt-cache policy firefox-3.0 firefox-3.5 firefox-3.6
firefox-3.0:
  Installed: 3.0.8+nobinonly-0ubuntu2
  Candidate: 3.0.8+nobinonly-0ubuntu2
  Version table:
 *** 3.0.8+nobinonly-0ubuntu2 0
        500 http://archive.ubuntu.com jaunty/main Packages
        100 /var/lib/dpkg/status
firefox-3.5:
  Installed: 3.5~b4~hg20090330r24021+nobinonly-0ubuntu1
  Candidate: 3.5~b4~hg20090330r24021+nobinonly-0ubuntu1
  Version table:
 *** 3.5~b4~hg20090330r24021+nobinonly-0ubuntu1 0
        500 http://archive.ubuntu.com jaunty/universe Packages
        100 /var/lib/dpkg/status
     3.5~b4~hg20090330r24021+nobinonly-0ubuntu1~fta1 0
        500 http://ppa.launchpad.net jaunty/main Packages
firefox-3.6:
  Installed: 3.6~a1~hg20090330r26723+nobinonly-0ubuntu1~fta1
  Candidate: 3.6~a1~hg20090330r26723+nobinonly-0ubuntu1~fta1
  Version table:
 *** 3.6~a1~hg20090330r26723+nobinonly-0ubuntu1~fta1 0
        500 http://ppa.launchpad.net jaunty/main Packages
        100 /var/lib/dpkg/status

$ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description: Ubuntu jaunty (development branch)
Release: 9.04
Codename: jaunty

$ apt-cache policy firefox-3.0 firefox-3.5 firefox-3.6
firefox-3.0:
  Installed: 3.0.8+nobinonly-0ubuntu3
  Candidate: 3.0.8+nobinonly-0ubuntu3
  Version table:
 *** 3.0.8+nobinonly-0ubuntu3 0
        500 ftp://darkstar.ist.utl.pt jaunty/main Packages
        500 ftp://archive.ubuntu.com jaunty/main Packages
        100 /var/lib/dpkg/status
firefox-3.5:
  Installed: 3.5~b4~hg20090407r24256+nobinonly-0ubuntu1~umd1
  Candidate: 3.5~b4~hg20090407r24256+nobinonly-0ubuntu1~umd1
  Version table:
 *** 3.5~b4~hg20090407r24256+nobinonly-0ubuntu1~umd1 0
        500 http://ppa.launchpad.net jaunty/main Packages
        100 /var/lib/dpkg/status
     3.5~b4~hg20090330r24021+nobinonly-0ubuntu1 0
        500 ftp://darkstar.ist.utl.pt jaunty/universe Packages
        500 ftp://archive.ubuntu.com jaunty/universe Packages
     3.5~b4~hg20090330r24021+nobinonly-0ubuntu1~fta1 0
        500 http://ppa.launchpad.net jaunty/main Packages
firefox-3.6:
  Installed: 3.6~a1~hg20090404r26915+nobinonly-0ubuntu1~umd1
  Candidate: 3.6~a1~hg20090404r26915+nobinonly-0ubuntu1~umd1
  Version table:
 *** 3.6~a1~hg20090404r26915+nobinonly-0ubuntu1~umd1 0
        500 http://ppa.launchpad.net jaunty/main Packages
        100 /var/lib/dpkg/status
     3.6~a1~hg20090330r26723+nobinonly-0ubuntu1~fta1 0
        500 http://ppa.launchpad.net jaunty/main Packages

$ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description: Ubuntu jaunty
Release: 9.04
Codename: jaunty

No one has not shown me an example outside orf Launchpad, until than i can only assume its LP reopened task. If this is not a LP problem please provide a reason or 2 so ican file it upstream (would love another site this happens on before i report bug upstream

Opera Works ok
$ apt-cache policy opera
opera:
  Installed: 9.64.2480.gcc4.qt3
  Candidate: 9.64.2480.gcc4.qt3
  Version table:
 *** 9.64.2480.gcc4.qt3 0
        500 http://deb.opera.com stable/non-free Packages
        500 http://deb.opera.com unstable/non-free Packages
        100 /var/lib/dpkg/status

lynx too (see attach)
$ apt-cache policy lynx
lynx:
  Installed: 2.8.7dev11-2
  Candidate: 2.8.7dev11-2
  Version table:
 *** 2.8.7dev11-2 0
        500 ftp://darkstar.ist.utl.pt jaunty/main Packages
        500 ftp://archive.ubuntu.com jaunty/main Packages
        100 /var/lib/dpkg/status

Konqueror Fails
$ apt-cache policy konqueror
konqueror:
  Installed: 4:4.2.2-0ubuntu3
  Candidate: 4:4.2.2-0ubuntu3
  Version table:
 *** 4:4.2.2-0ubuntu3 0
        500 ftp://darkstar.ist.utl.pt jaunty/main Packages
        500 ftp://archive.ubuntu.com jaunty/main Packages
        100 /var/lib/dpkg/status

so i guess this is not Genko specific?

doesn't seem to be related to Mozilla browser but to Lp from above comment by BUGabundo
Closing Mozilla tasks

To help with debugging, I have attached a fully reduced test case for the issue showing the <pre> with white-space css property.

The HTML validates, the CSS doesn't as it is using browser-specific -moz-pre-wrap -o-pre-wrap white-space properties.

I have fixed the border width to 320px. firefox-3.0 correctly wraps the text within this, firefox-3.5 doesn't

http://oldman.litmusapp.com/pub/f2b2bb2
^ results here show Internet Explorer 7.0 and Firefox 2.0 on Windows are both happy with this CSS+HTML

some more examples in the attached browsershots.zip (these are the original launchpad page rather than the reduced test case)

Safari 4.0 is interesting, it wraps within the border successfully but breaks on character rather than word boundaries

please confirm whether the reduced test case is a firefox-3.5 rendering problem or a misuse/misunderstanding of the -moz-pre-wrap -o-pre-wrap white-space properties?

raised upstream on mozilla bugzilla

Confirm upstream to not be a bug in firefox, but a bug in launchpad

{{{
Thanks for reporting.

This is no bug. Since Firefox 3.0 the CSS 2.1 standardized pre-wrap value is
available. Support for -moz-pre-wrap was thus dropped from Firefox 3.1 in bug
433065.

If it's necessary to keep compatible to Firefox versions prior to 3.0, please
use both values, e.g.:

white-space: -moz-pre-wrap;
white-space: pre-wrap;
}}}

so launchpad's CSS needs to be updated to include both values

https://bugzilla.mozilla.org/show_bug.cgi?id=433065

confirmed that adding

 white-space: pre-wrap;

as an additional property in the CSS in the reduced test case fixes the issue on firefox-3.5 and firefox-3.6

Marking as low because firefox 3.5 is not released yet. I'll update the description to point to mozilla's bug and add the solution provided by Dominic. Thanks.

small addition, it has now been decided at uds that firefox 3.5 will replace firefox 3.0 as the default (i.e. main) firefox in karmic soon.

The importance of this bug is increasing; Firefox 3.5 will be released soon, and might be the default in Karmic even sooner. Lots of people are using Karmic.

Using firebug, the code review comments do use: <pre style="white-space: pre-wrap;">, not the -moz-pre-wrap.

So I'm unclear as what to do.

I'm using firebug with firefox 3.5, and the style of the comment is "word-wrap: break-word;" (invalid css afaik) in the following proposal:

https://code.launchpad.net/~renatosilva/bzr-java-lib/log-view-fix/+merge/8377.

Just to confirm this is still a problem in Firefox 3.5.1 and Konqueror.

Since comments and merge proposals use similar style boxes, would it not be possible to borrow the bug-comment class (comments are surrounded with <div class="bug-comment"></div>) for use in merge proposals? Bug comments seem to work just fine.

On Sun, 19 Jul 2009 16:54:37 Adam Blackburn wrote:
> Just to confirm this is still a problem in Firefox 3.5.1 and Konqueror.
>
> Since comments and merge proposals use similar style boxes, would it not
> be possible to borrow the bug-comment class (comments are surrounded
> with <div class="bug-comment"></div>) for use in merge proposals? Bug
> comments seem to work just fine.

Yes, I'll take a look at this.

  assignee thumper

It seems firebug confused me by showing the style when inspected as "white-space: pre-wrap" when in fact it wasn't at all.

Konqueror 4.2.4 also shows non-wrapping, which is fixed by adding pre-wrap, but it also doesn't show monospace font (which I find annoying).

It is my understanding that the "word-wrap: break-word" is there for some obscure IE compatibility (IE/Win and Saf 1.3+ only according to a quick google).

I don't like monospace fonts for bug and proposal comments. I'd use them for source codes only.

Fixed in RF 8983.