global search oopses from incomplete XML

Bug #246932 reported by Curtis Hovey
4
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Curtis Hovey

Bug Description

I see several oopses over the past few days like OOPS-920A433. They appear to be caused when the Google response XML is incomplete, or may be empty. Retries of the URL work, so I suspect connectivity may be factor.

We may want to catch these problems and show a message explaining that data was not available, and that the search should be tried again.

Related OOPSes: OOPS-1020F2123, OOPS-1059A3034

Curtis Hovey (sinzui)
Changed in launchpad:
status: New → Confirmed
Ursula Junque (ursinha)
description: updated
Revision history for this message
Curtis Hovey (sinzui) wrote :

We should update the error in the oopses to be clear when incomplete XML was returned to Launchpad. The user should see an explanation in the pagematches location that the search was not returned, but it can be tried again.

Changed in launchpad-foundations:
assignee: nobody → sinzui-is
importance: Undecided → High
milestone: none → 2.1.11
status: Confirmed → Triaged
Curtis Hovey (sinzui)
Changed in launchpad-foundations:
milestone: 2.1.11 → 2.1.12
Revision history for this message
Curtis Hovey (sinzui) wrote :

I have a plan. Next step, meet with someone who can say if my plan is sane.

Changed in launchpad-foundations:
status: Triaged → In Progress
Ursula Junque (ursinha)
description: updated
Revision history for this message
Curtis Hovey (sinzui) wrote :

OOPS-1059A3034 is reproducible. I have captured the response XML from Google. It has only one match. I will add the XML to our test cases to verify it is handled correctly by _parse_google_search_protocol().

Revision history for this message
Curtis Hovey (sinzui) wrote :

Fixed in RF 7456.

Changed in launchpad-foundations:
status: In Progress → Fix Committed
Revision history for this message
Curtis Hovey (sinzui) wrote :

Release in Launchpad 2.1.12.

Changed in launchpad-foundations:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.