Launchpad itself

Deactivated account still appear in 'subscribers'-portlet

Bug #238493 reported by Markus Korn
84
This bug affects 9 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Triaged
Low
Unassigned

Bug Description

In the 'also notified' section of the 'subscribers'-portlet on a bug page there are users listed whose acoount has obviously been deactivated. It would be nice to filter out this users to clean this unclear list a bit.

See original description

Related branches

lp:~wallyworld/launchpad/blueprint-subscriptions-tales-refactor
Curtis Hovey (community): Approve (code)
Diff: 432 lines (+255/-65)
7 files modified
lib/lp/blueprints/browser/configure.zcml (+23/-3)
lib/lp/blueprints/browser/specification.py (+5/-4)
lib/lp/blueprints/browser/specificationsubscription.py (+93/-0)
lib/lp/blueprints/browser/tests/test_specificationsubscription.py (+49/-0)
lib/lp/blueprints/templates/specification-portlet-subscribers-content.pt (+22/-0)
lib/lp/blueprints/templates/specification-portlet-subscribers.pt (+12/-58)
lib/lp/blueprints/templates/specification-subscriber-row.pt (+51/-0)
Diogo Matsubara (matsubara)
description: updated
Changed in launchpad:
status: New → Confirmed
Revision history for this message
Martin Pool (mbp) wrote :

Is this a dupe of bug 248223?

Curtis Hovey (sinzui)
Changed in launchpad-registry:
importance: Undecided → Low
status: Confirmed → Triaged
Revision history for this message
Martin Albisetti (beuno) wrote :

"me too" :)

Curtis Hovey (sinzui)
tags: added: merge-deactivate
removed: registry
Revision history for this message
Curtis Hovey (sinzui) wrote :

I think we want a garbo job to clean this up daily.

Ian Booth (wallyworld)
Changed in launchpad:
assignee: nobody → Ian Booth (wallyworld)
status: Triaged → In Progress
Revision history for this message
Curtis Hovey (sinzui) wrote :

I believe blueprints was fixed by changing the app. The data is still wrong. I do not think this bug will really be fixed until users who are not getting notifications are removed from the tables that say they will get notifications.

Changed in launchpad:
assignee: Ian Booth (wallyworld) → nobody
status: In Progress → Triaged
Revision history for this message
Robert Collins (lifeless) wrote :

Isn't this just 'use the person load helper everywhere' which will naturally hide deactivated accounts (or can be taught to, in one place)

Revision history for this message
Curtis Hovey (sinzui) wrote :

Maybe the person load helper can do this. Most code in this situation uses the model which claims to provide a sane list already.

I do not think the proper fix is more guards in the code. there are 10,000 (bug, blueprint, question, ...) subscription belonging to merged-deactivated persons. We query them ever few minutes or less. Our send mail code is dropping email to them at the last minute. This data does not belong in the database. As I proposed in another bug, we could use a garbo job to purge the many forms of subscription. We can have a grace period for a few days so for deactivated/suspended users so that nothing is lot of the account is reinstated.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.