IPOTemplate.path says it's not required
Bug #615673 reported by
Jeroen T. Vermeulen
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Jeroen T. Vermeulen | ||
Bug Description
In the IPOTemplate interface, "path" is defined as non-required, and the edit form will accept an empty path field. Which then leads to an oops.
We should mark that field as required or, if that should prove impossible for whatever reason, at least make the form catch and reject empty paths.
OOPS-1682F553
Related branches
lp:~jtv/launchpad/bug-615673
- Graham Binns (community): Approve (code)
-
Diff: 25 lines (+2/-2)2 files modifiedlib/lp/translations/interfaces/potemplate.py (+1/-1)
lib/lp/translations/model/potemplate.py (+1/-1)
| Changed in rosetta: | |
| status: | New → Triaged |
| importance: | Undecided → High |
Revision history for this message
| Jeroen T. Vermeulen (jtv) wrote | #1 |
| Changed in rosetta: | |
| status: | Triaged → In Progress |
| assignee: | nobody → Jeroen T. Vermeulen (jtv) |
| milestone: | none → 10.09 |
| Changed in rosetta: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote Bug fixed by a commit | #2 |
| tags: | added: qa-needstesting |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in rosetta: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
As an experiment I tried making it a required field in both the interface and the model class (see attached branch) and none of the Translations tests broke. It's not quite worth the time to write tests for the change though, so I'll leave it at that.