delete milestone conjoined bug

Bug #522599 reported by Curtis Hovey
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Curtis Hovey

Bug Description

OOPS-1507A1604, shows that the act of untargeting a bugtask fails when it is conjoined. This is contrary to the intended rules where the bugtask should be deleted...removing the insane conjoined situation.

Related branches

Curtis Hovey (sinzui)
Changed in launchpad-registry:
milestone: series-future → 10.09
assignee: nobody → Curtis Hovey (sinzui)
status: Triaged → In Progress
Curtis Hovey (sinzui)
Changed in launchpad-registry:
status: In Progress → Fix Committed
Revision history for this message
Launchpad QA Bot (lpqabot) wrote : Bug fixed by a commit
tags: added: qa-needstesting
Curtis Hovey (sinzui)
tags: added: qa-bad
removed: qa-needstesting
Revision history for this message
Curtis Hovey (sinzui) wrote :

This fix is bad. We need to land a correct fix very quickly to prevent the last attempted fix from introducing bad data. The slave was deleted in my QA on edge, but we wanted to delete the master. ie. https://bugs.edge.launchpad.net/gdp/trunk/+bug/420173 shows a master bug without a slave. The master is targeted to a series, which make no sense since there is no bug in the project. This may require SQL to fix.

This bad chunk:
            if bugtask.conjoined_master is not None:
                Store.of(bugtask).remove(bugtask)
 should be:
            if bugtask.conjoined_master is not None:
                Store.of(bugtask.conjoined_master).remove(bugtask)

Revision history for this message
Curtis Hovey (sinzui) wrote :

I was still being idiotic. The correct fix, as pointed out by edwin-grubbs is:
            if bugtask.conjoined_master is not None:
                Store.of(bugtask).remove(bugtask.conjoined_master)

And the data was fixed by Edwin by using affects projects link to add a gdp bugtask back to the bug. The lesson learned is that conjoined bugs are very loosely coupled. The relationship is inferred from state.

Curtis Hovey (sinzui)
Changed in launchpad-registry:
status: Fix Committed → In Progress
Curtis Hovey (sinzui)
Changed in launchpad-registry:
status: In Progress → Fix Committed
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :
tags: added: qa-needstesting
removed: qa-bad
Curtis Hovey (sinzui)
tags: added: qa-ok
removed: qa-needstesting
Curtis Hovey (sinzui)
Changed in launchpad-registry:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.