Remove launchpad-addform.pt and launchpad-editform.pt

Bug #433074 reported by Gary Poster
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Curtis Hovey

Bug Description

These two templates are only used for their macros.

  lib/canonical/launchpad/templates/launchpad-addform.pt
  lib/canonical/launchpad/templates/launchpad-editform.pt

Here are the two usages of the add form:

./lib/lp/registry/templates/signedcodeofconduct-acknowledge.pt:11: <div metal:use-macro="context/@@launchpad_addform/addform"/>
./lib/lp/blueprints/templates/specification-requestfeedback.pt:23: <div metal:use-macro="context/@@launchpad_addform/addform">

Here are the two usages of the edit form:

./lib/lp/registry/templates/signedcodeofconduct-activate.pt:11: <div metal:use-macro="context/@@launchpad_editform/editform"/>
./lib/lp/registry/templates/signedcodeofconduct-deactivate.pt:11: <div metal:use-macro="context/@@launchpad_editform/editform"/>

Can the few templates that use these the launchpad_addform and launchpad_editform macros can be updated not to use them? If these macros are still necessary, the <h1> in these macros needs to be removed at the same time that the templates using them are converted to UI 3.0. Otherwise, there will be duplicate <h1> tags.

Related branches

Curtis Hovey (sinzui)
Changed in launchpad-registry:
milestone: none → 3.1.10
importance: Undecided → High
status: New → Triaged
Curtis Hovey (sinzui)
tags: added: post-3-ui-cleanup
tags: added: infrastructure
Curtis Hovey (sinzui)
tags: added: tech-debt
removed: infrastructure
Curtis Hovey (sinzui)
Changed in launchpad-registry:
milestone: 3.1.10 → none
tags: removed: post-3-ui-cleanup
Curtis Hovey (sinzui)
Changed in launchpad-registry:
milestone: none → series-3.1
Curtis Hovey (sinzui)
Changed in launchpad-registry:
milestone: series-future → 10.11
assignee: nobody → Curtis Hovey (sinzui)
status: Triaged → In Progress
Curtis Hovey (sinzui)
Changed in launchpad-registry:
status: In Progress → Fix Committed
Revision history for this message
Launchpad QA Bot (lpqabot) wrote : Bug fixed by a commit
tags: added: qa-needstesting
Curtis Hovey (sinzui)
tags: added: qa-ok
removed: qa-needstesting
Changed in launchpad-registry:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.