Remove launchpad-addform.pt and launchpad-editform.pt
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
High
|
Curtis Hovey |
Bug Description
These two templates are only used for their macros.
lib/canonical
lib/canonical
Here are the two usages of the add form:
./lib/lp/
./lib/lp/
Here are the two usages of the edit form:
./lib/lp/
./lib/lp/
Can the few templates that use these the launchpad_addform and launchpad_editform macros can be updated not to use them? If these macros are still necessary, the <h1> in these macros needs to be removed at the same time that the templates using them are converted to UI 3.0. Otherwise, there will be duplicate <h1> tags.
Related branches
- Paul Hummer (community): Approve
-
Diff: 833 lines (+251/-446)12 files modifiedlib/canonical/launchpad/templates/launchpad-addform.pt (+0/-81)
lib/canonical/launchpad/templates/launchpad-editform.pt (+0/-104)
lib/canonical/launchpad/zcml/configure.zcml (+0/-2)
lib/canonical/launchpad/zcml/widgets.zcml (+0/-46)
lib/lp/app/browser/configure.zcml (+14/-0)
lib/lp/registry/browser/codeofconduct.py (+52/-118)
lib/lp/registry/browser/configure.zcml (+6/-18)
lib/lp/registry/browser/tests/test_codeofconduct.py (+149/-0)
lib/lp/registry/stories/gpg-coc/98-cocacknowledge.txt (+30/-29)
lib/lp/registry/templates/signedcodeofconduct-acknowledge.pt (+0/-16)
lib/lp/registry/templates/signedcodeofconduct-activate.pt (+0/-16)
lib/lp/registry/templates/signedcodeofconduct-deactivate.pt (+0/-16)
Changed in launchpad-registry: | |
milestone: | none → 3.1.10 |
importance: | Undecided → High |
status: | New → Triaged |
tags: | added: post-3-ui-cleanup |
tags: | added: infrastructure |
tags: |
added: tech-debt removed: infrastructure |
Changed in launchpad-registry: | |
milestone: | 3.1.10 → none |
tags: | removed: post-3-ui-cleanup |
Changed in launchpad-registry: | |
milestone: | none → series-3.1 |
Changed in launchpad-registry: | |
milestone: | series-future → 10.11 |
assignee: | nobody → Curtis Hovey (sinzui) |
status: | Triaged → In Progress |
Changed in launchpad-registry: | |
status: | In Progress → Fix Committed |
tags: |
added: qa-ok removed: qa-needstesting |
Changed in launchpad-registry: | |
status: | Fix Committed → Fix Released |
Fixed in stable r11711 <http:// bazaar. launchpad. net/~launchpad- pqm/launchpad/ stable/ revision/ 11711>.