Update project page to UI 3.0

Bug #405916 reported by Curtis Hovey
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Curtis Hovey

Bug Description

Switch the layout to main_side
Update the css ids and classes of the portlets

This bug requires that bug 403641 [base-layout must support a global object menu]
and bug 403651 [base-layout must support an Involvement menu] be solved too.

Revision history for this message
Curtis Hovey (sinzui) wrote :

Hi Martin.

Take a look at https://devpad.canonical.com/~curtis/product/ where I have placed some screencaps of
how projects look using the new design.

The Get Involved and global action menus need some work. If their presentation is good (or good enough), I can extract them to work as menus so that the sections do not appear when there are not links for the user to act on.

There is some spacing issues in regards to the heading/icon, but I do not expect to land this kind of heading since Michael is working on the new heading.

I think we need to remove the 2.0 font hacks that were added last cycle to get the fonts to look like the design.

See the sprints section at the bottom? We need a home for that, or another section to pair with it.

Revision history for this message
Martin Albisetti (beuno) wrote :

I love it.
Minus the hide-empty-sections bit I brought up on IRC, I'm very happy with this!

Revision history for this message
Curtis Hovey (sinzui) wrote :

Hi Martin.

yui-g, yui-u, and first combinations are very problematic with content that may not render:

This is what happens:
    https://devpad.canonical.com/~curtis/yui-columns/firefox-3.0-missing-rows.png

So explored a simple two column approach where the guaranteed portlets are first:
    https://devpad.canonical.com/~curtis/yui-columns/firefox-one-yui-g-best.png

But this can still look bad in the extreme cases.
    https://devpad.canonical.com/~curtis/yui-columns/firefox-one-yui-g-worst.png

So I tried this, two columns on guaranteed, a page width of optional, then two columns of optional
    https://devpad.canonical.com/~curtis/yui-columns/firefox-two-yui-g.png

My last effort does require a lot more thinking on the part of the engineer. the middle fix is actually the easiest implementation we can take with migrate to 3.0

Revision history for this message
Martin Albisetti (beuno) wrote :

I don't understand the moving parts behind this very well, but option 4 seems like the best result:
https://devpad.canonical.com/~curtis/yui-columns/firefox-two-yui-g.png

Revision history for this message
Curtis Hovey (sinzui) wrote :

Martin.

Let me explain the underlying implementation:

YUI classes:
    yui-g is a row making class
    yui-u is a column making class
    first declares which column is first

This is a lot like using tables to do layout...we have a td issue.

Since the design wanted nice alignments, I used many yui-g to make rows, and in each row are two columns (2 yui-u). Some times the content of a column does not render, creating missing row parts.

I switched to a single row (1 yui-g) with two columns (2 yui-u), I put lots of portlets in each column The spaces fill in, but we loose the nice row alignment

So I tried an alternate approach where I create three rows (yui-g), where the first and third has two columns, and the second is one column. The first row is guaranteed to exist, the second and third are optional. By making the second row a single column, it fills the space better.

Revision history for this message
Martin Albisetti (beuno) wrote :

I see, thanks for the insight.
If #2 is so much better for the engineers, then I'd say we need to find a way for the right column it to not cut into the top section (maybe a min-height?), and work a bit on vertical spacing to give the information and sections some air. It can be done.

Revision history for this message
Curtis Hovey (sinzui) wrote :

Fix committed in launchpad devel r9090.

Changed in launchpad-registry:
status: In Progress → Fix Committed
Revision history for this message
Curtis Hovey (sinzui) wrote : Bug 405916 Fix released

Fixed released in launchpad-project 2.2.8.

Changed in launchpad-registry:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.