Launchpad itself

checking menu links

Bug #296927 reported by Edwin Grubbs
2
Affects Status Importance Assigned to Milestone
Launchpad itself
Triaged
Low
Unassigned

Bug Description

doc/product-menus.txt is able to check most menu links very efficiently by looking up the view for the context object, however, some of the links need to be traversed completely. The pagetests can do this, but that is much slower, since actually loads the page. It would be much more efficient to just confirm that the view for the url exists without having the view render itself.

Curtis Hovey (sinzui)
Changed in launchpad-registry:
importance: Undecided → Wishlist
status: New → Triaged
Revision history for this message
Данило Шеган (danilo) wrote :

I'm switching ProductTranslationsMenu to NavigationMenu (see bug 300276 and a related branch), which means that there will be a few changes in behaviour. I am putting a test inside doc/menu-pages.txt for now, but will be happy to make few methods from that test into test helpers (make_request_for_obj, print_menu_view_links), and move the test to doc/product-menus.txt.

Unfortunately, I have noticed that no existing NavigationMenus are actually tested directly, so it seems everybody is doing the testing inside pagetests.

Curtis Hovey (sinzui)
tags: added: tech-debt
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.